Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(await-async-event): pluralize to await-async-events #670

Merged
merged 1 commit into from Oct 5, 2022
Merged

fix(await-async-event): pluralize to await-async-events #670

merged 1 commit into from Oct 5, 2022

Conversation

skovy
Copy link
Collaborator

@skovy skovy commented Oct 5, 2022

Checks

  • I have read the contributing guidelines.
  • If some rule is added/updated/removed, I've regenerated the rules list (npm run generate:rules-list)
  • If some rule meta info is changed, I've regenerated the plugin shared configs (npm run generate:configs)

Changes

  • I originally goofed on the naming of this rule when renaming, it should be plural.

Context

Fully resolves #626.

@skovy skovy added the v6 Next major v6 label Oct 5, 2022
Belco90
Belco90 reviewed Oct 5, 2022
View reviewed changes
Copy link
Member

@Belco90 Belco90 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We need to update the migration doc, right?

@skovy
Copy link
Collaborator Author

skovy commented Oct 5, 2022 •
edited

@Belco90 I believe I did that in the other PR since they were both open at the same time, but I can double check 👍

Belco90
Belco90 approved these changes Oct 5, 2022
View reviewed changes
Copy link
Member

@Belco90 Belco90 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You are right! The migration docs were fine already.

@Belco90 Belco90 merged commit 7238f76 into alpha Oct 5, 2022
@Belco90 Belco90 deleted the pr/fix-await-async-events-name branch October 5, 2022 21:43
@github-actions
Copy link

github-actions bot commented Oct 5, 2022

🎉 This PR is included in version 6.0.0-alpha.12 🎉

The release is available on:

Your semantic-release bot 📦🚀

@github-actions
Copy link

🎉 This PR is included in version 6.0.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Belco90 Belco90 Belco90 approved these changes

Assignees
No one assigned
Labels
hacktoberfest-accepted released on @alpha released v6 Next major v6
Projects
No open projects
eslint-plugin-testing-library v6
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@skovy @Belco90 @MichaelDeBoey