feat(console): export helper to manually suppress error output #571
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mpeyper
commented
Mar 1, 2021
| }) | ||
|
|
||
| test('should not patch console.error', () => { | ||
| require('..') |
There was a problem hiding this comment.
This actually wasn't testing anything. Requiring in the test wouldn't register the beforeEach and afterEach so it must be done before the test executes. I discovered this because with the refactoring, this left a uncovered branch that is now covered.
Codecov Report
@@ Coverage Diff @@
## master #571 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 15 15
Lines 218 219 +1
Branches 31 29 -2
=========================================
+ Hits 218 219 +1
Continue to review full report at Codecov.
|
joshuaellis
approved these changes
Mar 1, 2021
|
🎉 This PR is included in version 5.1.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
This was referenced Mar 8, 2021
This was referenced Mar 15, 2021
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What:
Add a helper to suppress the error output in the same way the automatic suppression does for users that can't use the automatic version.
Also extended the documentation around this feature to describe the requirements for automatic suppression and give instructions on how to do it manually.
Why:
#564
How:
extracted the logic from the
beforeEachandafterEachand exported them from all the modules.Checklist: