Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change mockImplementationOnce to mockResolvedValueOnce #83

Merged
merged 1 commit into from
May 8, 2018

Conversation

Gpx
Copy link
Member

@Gpx Gpx commented May 8, 2018

What: In the README's example instead of using mockImplementationOnce the code is now using mockReturnValueOnce.

Why: mockReturnValueOnce is shorter and easier to read making the example easier to follow.

How: N/A

Checklist:

  • Documentation
  • Tests N/A
  • Ready to be merged
  • Added myself to contributors table N/A

Copy link
Member

@kentcdodds kentcdodds left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Super! Thanks!

@kentcdodds kentcdodds merged commit 6e1b0e9 into testing-library:master May 8, 2018
@Gpx Gpx deleted the patch-1 branch May 8, 2018 15:10
@kentcdodds
Copy link
Member

🎉 This PR is included in version 3.1.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

julienw pushed a commit to julienw/react-testing-library that referenced this pull request Dec 20, 2018
…getByTitle` (testing-library#86)

* Add ability to select `title` element of SVG with `getByTitle`

Close testing-library#83

* Add assertion with `{ exact: false }`
lucbpz pushed a commit to lucbpz/react-testing-library that referenced this pull request Jul 26, 2020
chore: 🤖 update react-testing-library
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants