feat(keyboard): apply modifier state #815
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What:
Apply modifier state. See https://www.w3.org/TR/uievents/#dom-keyboardevent-getmodifierstate
Why:
Closes #812
How:
Keep track of modifier states on
keyboardState
.Apply modifier states on keyboard and pointer events.
Checklist:
Additional information:
In the browser e.g.
getModifierState('Shift')
returnstrue
ifshiftKey: true
is set on theEventInit
.In Jsdom
getModifierState
is implemented for e.g.modifierCapsLock
but fails forAlt
,Control
,Meta
andShift
.