Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove remaining implicit global #990

Merged
merged 2 commits into from
Jul 15, 2022
Merged

remove remaining implicit global #990

merged 2 commits into from
Jul 15, 2022

Conversation

ph-fritsche
Copy link
Member

What:

Flag more implicit globals when linting.
Replace implicit global FileList with window.FileList.

Why:

See #932

How:

Don't allow ImplicitLibVariable.
Whitelist standard built-in objects.
Ignore types.

Checklist:

  • Tests
  • Ready to be merged

@codesandbox-ci
Copy link

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit c88865d:

Sandbox Source
userEvent-dom Configuration
userEvent-react Configuration

@codecov
Copy link

codecov bot commented Jul 15, 2022

Codecov Report

Merging #990 (c88865d) into main (cf5faed) will not change coverage.
The diff coverage is 100.00%.

@@            Coverage Diff            @@
##              main      #990   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           86        86           
  Lines         1836      1838    +2     
  Branches       678       678           
=========================================
+ Hits          1836      1838    +2     
Impacted Files Coverage Δ
src/utility/upload.ts 100.00% <100.00%> (ø)
src/utils/dataTransfer/DataTransfer.ts 100.00% <100.00%> (ø)
src/utils/dataTransfer/FileList.ts 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cf5faed...c88865d. Read the comment docs.

@ph-fritsche ph-fritsche merged commit c88865d into main Jul 15, 2022
@ph-fritsche ph-fritsche deleted the chore branch July 15, 2022 09:23
@github-actions
Copy link

🎉 This PR is included in version 14.2.4 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant