Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make fireEvent.update work with lazy modifier #183

Merged
merged 1 commit into from
Nov 24, 2020

Conversation

kinoli
Copy link
Contributor

@kinoli kinoli commented Nov 24, 2020

  • switched to use change event if lazy modifier is found on element
  • updated form unit test to test lazy input and textarea

- switched to use change event if lazy modifier is found on element
- updated form unit test to test lazy input and textarea
@codecov
Copy link

codecov bot commented Nov 24, 2020

Codecov Report

Merging #183 (b6eae4f) into master (4376e64) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff            @@
##            master      #183   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            1         1           
  Lines           94        98    +4     
  Branches        32        34    +2     
=========================================
+ Hits            94        98    +4     
Impacted Files Coverage Δ
src/vue-testing-library.js 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4376e64...b6eae4f. Read the comment docs.

Copy link
Member

@afontcu afontcu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good catch!

@afontcu afontcu merged commit 853d998 into testing-library:master Nov 24, 2020
@github-actions
Copy link

🎉 This PR is included in version 5.5.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

@afontcu
Copy link
Member

afontcu commented Nov 24, 2020

This is gonna be interesting to implement in Vue 3 😅

@github-actions
Copy link

github-actions bot commented Jun 8, 2022

🎉 This PR is included in version 6.6.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants