Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

for snapshot versions, replace '-SNAPSHOT' with timestamp '.{yyyymmddhhmmss}' #10

Closed
missedone opened this issue Oct 11, 2016 · 3 comments

Comments

@missedone
Copy link
Contributor

for snapshot versions, it's better to replace '-SNAPSHOT' with timestamp '.{yyyymmddhhmmss}' so that when the actual snapshot updated, the user can use the new build otherwise, user won't see the update.

the behavior will be similar as what Maven Tycho plugin did, update the version in MANIFEST.MF, and appends to bundle file name

mschreiber added a commit to mschreiber/testng-p2 that referenced this issue Oct 14, 2016
Fix for testng-team#10, replacing 'SNAPSHOT' for testNG bundle with the current
build time using yyyyMMddHHmmss
mschreiber added a commit that referenced this issue Oct 14, 2016
Fix for #10, replacing 'SNAPSHOT' for testNG bundle with the current
build time using yyyyMMddHHmmss
@mschreiber
Copy link
Collaborator

Not sure if my last commit is what we want. Strange is, that the feature version is still using some hash but the testng plugin does use the timestamp qualifier...

@missedone
Copy link
Contributor Author

for released version (e.g. 6.9.12), that's good, i don't mind the hashing suffix of the feature jar as long as the feature.xml is correct. but yes, that's weird.
I think when dealing with the snapshot version (replacing snapshot with qualifier timestamp), we will learn more about that then.

@missedone
Copy link
Contributor Author

with help of stempler/bnd-platform#20, commit 444b700, the output now looks quite good:

ll build/updatesite/*
-rw-r--r-- 1 nick staff  960 Oct 21 07:14 build/updatesite/artifacts.jar
-rw-r--r-- 1 nick staff 2.1K Oct 21 07:14 build/updatesite/content.jar

build/updatesite/features:
total 4.0K
-rw-r--r-- 1 nick staff 412 Oct 21 07:14 org.testng.p2.feature_6.9.13.20161021141424.jar

build/updatesite/plugins:
total 2.1M
-rw-r--r-- 1 nick staff  55K Oct 21 07:14 com.beust.jcommander.source_1.48.0.jar
-rw-r--r-- 1 nick staff  63K Oct 21 07:14 com.beust.jcommander_1.48.0.jar
-rw-r--r-- 1 nick staff 296K Oct 21 07:14 org.apache-extras.beanshell.bsh.source_2.0.0.b6.jar
-rw-r--r-- 1 nick staff 385K Oct 21 07:14 org.apache-extras.beanshell.bsh_2.0.0.b6.jar
-rw-r--r-- 1 nick staff 476K Oct 21 07:14 org.testng.source_6.9.13.20161021141424.jar
-rw-r--r-- 1 nick staff 840K Oct 21 07:14 org.testng_6.9.13.20161021141424.jar

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants