Implement a reusable webview fragment with SSO login support #524
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
PruthiviRaj27
commented
May 17, 2023
•
PruthiviRaj27
commented
- In this commit Add a Webview fragment with SSO login support
- This can be reused in any activity/fragment
- This will reduce redundant code.
PruthiviRaj27
force-pushed
the
webview_fragment
branch
2 times, most recently
from
9ddeeea
to
f35c6a8
Compare
PruthiviRaj27
force-pushed
the
webview_fragment
branch
from
6355f15
to
6fc9549
Compare
PruthiviRaj27
force-pushed
the
webview_fragment
branch
from
d10615d
to
8e0ac31
Compare
Karthik-0
reviewed
Jun 8, 2023
Comment on lines
50
to
53
| private var mCM: String? = null | ||
| private var mUM: ValueCallback<Uri?>? = null | ||
| private var mUMA: ValueCallback<Array<Uri>?>? = null | ||
| private val FCR = 1 |
Karthik-0
reviewed
Jun 8, 2023
| } | ||
| } | ||
|
|
||
| override fun onActivityResult(requestCode: Int, resultCode: Int, intent: Intent?) { |
PruthiviRaj27
changed the title
Karthik-0
requested changes
Jun 8, 2023
Comment on lines
221
to
253
| if (Build.VERSION.SDK_INT >= 21) { | ||
| var results: Array<Uri>? = null | ||
|
|
||
| //Check if response is positive | ||
| if (resultCode == RESULT_OK) { | ||
| if (requestCode == FCR) { | ||
|
|
||
| if (mUMA == null) { | ||
| return | ||
| } | ||
| if (intent == null) { | ||
| //Capture Photo if no image available | ||
| if (mCM != null) { | ||
| results = arrayOf(Uri.parse(mCM)) | ||
| } | ||
| } else { | ||
| val dataString = intent.dataString | ||
| if (dataString != null) { | ||
| results = arrayOf(Uri.parse(dataString)) | ||
| } | ||
| } | ||
| } | ||
| } | ||
| mUMA?.onReceiveValue(results) | ||
| mUMA = null | ||
| } else { | ||
|
|
||
| if (requestCode == FCR) { | ||
| if (mUM == null) return | ||
| val result = if (intent == null || resultCode != RESULT_OK) null else intent.data | ||
| mUM?.onReceiveValue(result) | ||
| mUM = null | ||
| } |
Comment on lines
310
to
349
| private inner class CustomWevChromeClient : WebChromeClient() { | ||
|
|
||
| override fun onShowFileChooser( | ||
| webView: WebView?, filePathCallback: ValueCallback<Array<Uri>?>?, | ||
| fileChooserParams: FileChooserParams? | ||
| ): Boolean { | ||
| if (mUMA != null) { | ||
| mUMA?.onReceiveValue(null) | ||
| } | ||
| mUMA = filePathCallback | ||
| var takePictureIntent: Intent? = Intent(MediaStore.ACTION_IMAGE_CAPTURE) | ||
| if (takePictureIntent!!.resolveActivity(this@WebViewFragment.requireActivity().packageManager) != null) { | ||
| var photoFile: File? = null | ||
| try { | ||
| photoFile = createImageFile() | ||
| takePictureIntent.putExtra("PhotoPath", mCM) | ||
| } catch (ex: IOException) { | ||
| Log.e(TAG, "Image file creation failed", ex) | ||
| } | ||
| if (photoFile != null) { | ||
| mCM = "file:" + photoFile.absolutePath | ||
| takePictureIntent!!.putExtra( | ||
| MediaStore.EXTRA_OUTPUT, | ||
| Uri.fromFile(photoFile) | ||
| ) | ||
| } else { | ||
| takePictureIntent = null | ||
| } | ||
| } | ||
| val contentSelectionIntent = Intent(Intent.ACTION_GET_CONTENT) | ||
| contentSelectionIntent.addCategory(Intent.CATEGORY_OPENABLE) | ||
| contentSelectionIntent.type = "*/*" | ||
| val intentArray: Array<Intent?> = | ||
| takePictureIntent?.let { arrayOf(it) } ?: arrayOfNulls(0) | ||
| val chooserIntent = Intent(Intent.ACTION_CHOOSER) | ||
| chooserIntent.putExtra(Intent.EXTRA_INTENT, contentSelectionIntent) | ||
| chooserIntent.putExtra(Intent.EXTRA_TITLE, "Image Chooser") | ||
| chooserIntent.putExtra(Intent.EXTRA_INITIAL_INTENTS, intentArray) | ||
| startActivityForResult(chooserIntent, FCR) | ||
| return true |
There was a problem hiding this comment.
Extract into meaningful methods?
Karthik-0
reviewed
Jun 9, 2023
| import java.text.SimpleDateFormat | ||
| import java.util.* | ||
|
|
||
| class CustomWevChromeClient(val fragment: WebViewFragment) : WebChromeClient() { |
Karthik-0
reviewed
Jun 9, 2023
core/src/main/java/in/testpress/util/webview/CustomWevChromeClient.kt
Outdated
Show resolved
Hide resolved
Karthik-0
approved these changes
Jun 12, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.