Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

apply active bar style to android #207

Closed
wants to merge 1 commit into from

Conversation

ardyfeb
Copy link

@ardyfeb ardyfeb commented Jul 15, 2019

When alert is open the status bar style not changed on android

@codecov-io
Copy link

Codecov Report

Merging #207 into master will decrease coverage by 0.78%.
The diff coverage is 0%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #207      +/-   ##
==========================================
- Coverage   90.39%   89.61%   -0.79%     
==========================================
  Files          11       11              
  Lines         229      231       +2     
==========================================
  Hits          207      207              
- Misses         22       24       +2
Impacted Files Coverage Δ
DropdownAlert.js 87.43% <0%> (-0.93%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6b4e874...6b7a070. Read the comment docs.

@testshallpass testshallpass self-requested a review August 12, 2019 01:04
@testshallpass
Copy link
Owner

I reworked your changes in PR: Fixes to constants, setBarStyle and unmount don't invoke closeAction #210. I'm going to add some more test coverage.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants