[A*] Improve Array type support by moving sort parsing logic from sort2type
into AstVisitor
#46
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I did some major changes on the handling of compound types, e.g.
(Array (Array X Y) Y)
. As far as I understand, in the current code:AstVisitor
converts this structure into textual representationsort2type
function converts sort strings back to type objects (ARRAY_TYPE
,BITVECTOR_TYPE
, etc.).I propose to eliminate
sort2type
entirely and produce structured type representations in theAstVisitor
directly, as done in this PR. This is only halfway done though, asBitVector
andFloatingPoint
is still parsed insort2type
.Apart from that it looks like Opfuzz uses
sort2type
for constructing rules, so if that is needed then we could movesort2type
into the opfuzz module.