Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bug Fix for issue #998 #1075

Merged
merged 2 commits into from
Aug 1, 2024
Merged

Bug Fix for issue #998 #1075

merged 2 commits into from
Aug 1, 2024

Conversation

jakeymac
Copy link
Contributor

Description

This merge request addresses issue #998 for basemap layers with typos, or empty basemap list in mapview. Now throws warnings in console for unsupported map layer names provided.

Changes Made to Code:

  • added 'add_default_basemap_layer' function
  • added warnings in console for invalid or misspelled basemap names

Related

None

Additional Notes

None

Quality Checks

  • [] New code is 100% tested
  • [] Code has been formated
  • [] Code has been linted
  • [] Docstrings for new methods have been added

@jakeymac
bug fix for issue #998 for basemap layers with typos, or empty basema…
f222d86 
…p layers list. Now throws warnings in console for unsupported map layer names provided.
@coveralls
Copy link

coveralls commented Jul 30, 2024 •
edited
Loading

Coverage Status

coverage: 99.936%. remained the same
when pulling 58d558f on bug-fix-998-v2
into 1a761f2 on main.

swainn
swainn requested changes Jul 31, 2024
View reviewed changes
Copy link
Member

@swainn swainn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One minor suggestion. I'd like to see a demo before I merge. Also, you need to create the minified and munged version that is used for production. @Sonia-96 did this recently, so you can ask her what she did.

tethys_gizmos/static/tethys_gizmos/js/tethys_map_view.js Outdated Show resolved Hide resolved
@swainn swainn merged commit ca4d514 into main Aug 1, 2024
31 of 32 checks passed
@swainn swainn deleted the bug-fix-998-v2 branch August 1, 2024 16:12
@swainn swainn mentioned this pull request Sep 6, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@swainn swainn swainn approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jakeymac @coveralls @swainn