Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug Fix for Issue #1080 #1085

Merged
merged 3 commits into from
Aug 27, 2024
Merged

Bug Fix for Issue #1080 #1085

merged 3 commits into from
Aug 27, 2024

Conversation

jakeymac
Copy link
Contributor

@jakeymac jakeymac commented Aug 26, 2024

Description

This merge request addresses the previous issue with controllers using app_media, user_media, app_public, and app_resources in controller decorators causing url map errors or not being found.

These parameters are now treated like user and app_workspace are treated in controller decorators.

Fixes #1080

Quality Checks

  • New code is 100% tested
  • Code has been formated
  • Code has been linted
  • Docstrings for new methods have been added

…_resources, app_public the same as app and user workspace, fixes issue #1080
@coveralls
Copy link

coveralls commented Aug 26, 2024

Coverage Status

coverage: 99.936%. remained the same
when pulling 4d43894 on user-media-url-bug-fix
into a9a7143 on main.

@jakeymac jakeymac requested review from swainn and sdc50 August 26, 2024 21:24
@swainn swainn merged commit fbf295d into main Aug 27, 2024
42 checks passed
@swainn swainn deleted the user-media-url-bug-fix branch August 27, 2024 17:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] controllers not being found when using user_media
3 participants