Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Map Layout Bug Fixes #931

Merged
merged 3 commits into from
Mar 10, 2023
Merged

Map Layout Bug Fixes #931

merged 3 commits into from
Mar 10, 2023

Conversation

swainn
Copy link
Member

@swainn swainn commented Mar 10, 2023

Use safe versions of layer_ids for legend ids.

@coveralls
Copy link

coveralls commented Mar 10, 2023 •
edited
Loading

Coverage Status

Coverage: 100.0%. Remained the same when pulling dd545b1 on map_layout_bug_fixes into f5a0292 on main.

@swainn swainn self-assigned this Mar 10, 2023
@swainn swainn added the bugfix label Mar 10, 2023
@swainn swainn marked this pull request as ready for review March 10, 2023 17:59
shawncrawley
shawncrawley approved these changes Mar 10, 2023
View reviewed changes
Copy link
Contributor

@shawncrawley shawncrawley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

@swainn swainn merged commit 505282b into main Mar 10, 2023
@swainn swainn deleted the map_layout_bug_fixes branch March 10, 2023 20:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shawncrawley shawncrawley shawncrawley approved these changes

@sdc50 sdc50 Awaiting requested review from sdc50

Assignees

@swainn swainn

Labels
bugfix
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@swainn @coveralls @shawncrawley