Fix getmesh fetchistioctl darwin arm64 #66
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: morfeo8marc@gmail.com <marcnavarro@tetrate.io>
…d test Signed-off-by: morfeo8marc@gmail.com <marcnavarro@tetrate.io>
toffentoffen
force-pushed
the
fix_fetchistioctl_darwin_arm64
branch
from
1a2a7d0
to
137a3b4
Compare
mathetake
reviewed
Aug 25, 2021
mathetake
reviewed
Aug 25, 2021
Co-authored-by: Takeshi Yoneda <yoneda.takeshi.md@alumni.tsukuba.ac.jp>
Signed-off-by: morfeo8marc@gmail.com <marcnavarro@tetrate.io>
if block ends with a return statement, so drop this else and outdent its block Signed-off-by: morfeo8marc@gmail.com <marcnavarro@tetrate.io>
mathetake
approved these changes
Aug 25, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds support to fetch the correct
istioctlbinary for darwin-arm64.Solves #64.
Although #24 generates
getmeshdarwin-arm64 binaries, the generated binary wasn't fetching the correctistioctlfor darwin-arm64.