Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

wazevo(amd64): lower Fabs, Fneg, Fadd, Fsub, Fdiv, Fmul, Fsqrt #1965

Merged
merged 14 commits into from
Jan 27, 2024

Conversation

evacchi
Copy link
Contributor

@evacchi evacchi commented Jan 26, 2024

Signed-off-by: Edoardo Vacchi evacchi@users.noreply.github.com

Signed-off-by: Edoardo Vacchi <evacchi@users.noreply.github.com>
Signed-off-by: Edoardo Vacchi <evacchi@users.noreply.github.com>
Signed-off-by: Edoardo Vacchi <evacchi@users.noreply.github.com>
Signed-off-by: Edoardo Vacchi <evacchi@users.noreply.github.com>
@evacchi evacchi changed the title wazevo(amd64): encoding for div and signExtendData wazevo(amd64): lower Fadd, Fsub, Fdiv, Fmul, Fsqrt; encode div, signExtendData Jan 26, 2024
Signed-off-by: Edoardo Vacchi <evacchi@users.noreply.github.com>
@evacchi evacchi changed the title wazevo(amd64): lower Fadd, Fsub, Fdiv, Fmul, Fsqrt; encode div, signExtendData wazevo(amd64): lower Fabs, Fneg, Fadd, Fsub, Fdiv, Fmul, Fsqrt; encode div, signExtendData Jan 26, 2024
Signed-off-by: Edoardo Vacchi <evacchi@users.noreply.github.com>
Copy link
Member

@mathetake mathetake left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can you delete dev and signExtendData related change?

@mathetake mathetake changed the title wazevo(amd64): lower Fabs, Fneg, Fadd, Fsub, Fdiv, Fmul, Fsqrt; encode div, signExtendData wazevo(amd64): lower Fabs, Fneg, Fadd, Fsub, Fdiv, Fmul, Fsqrt Jan 26, 2024
@mathetake
Copy link
Member

nvm, will do it myself.

Signed-off-by: Takeshi Yoneda <t.y.mathetake@gmail.com>
Signed-off-by: Edoardo Vacchi <evacchi@users.noreply.github.com>
Signed-off-by: Edoardo Vacchi <evacchi@users.noreply.github.com>
Signed-off-by: Edoardo Vacchi <evacchi@users.noreply.github.com>
@mathetake
Copy link
Member

sorry I will take over this.

This reverts commit 8c8c511.
Signed-off-by: Takeshi Yoneda <t.y.mathetake@gmail.com>
@mathetake
Copy link
Member

just so you know, the last three commits you made were unnecessarily made the code complex, and only you had to do was to fix the order of register. See 2a49278

@mathetake mathetake merged commit bc5917a into main Jan 27, 2024
56 checks passed
@mathetake mathetake deleted the amd64-moreops2 branch January 27, 2024 00:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants