-
Notifications
You must be signed in to change notification settings - Fork 259
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
wazevo(amd64): lower Fabs, Fneg, Fadd, Fsub, Fdiv, Fmul, Fsqrt #1965
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Edoardo Vacchi <evacchi@users.noreply.github.com>
Signed-off-by: Edoardo Vacchi <evacchi@users.noreply.github.com>
Signed-off-by: Edoardo Vacchi <evacchi@users.noreply.github.com>
Signed-off-by: Edoardo Vacchi <evacchi@users.noreply.github.com>
evacchi
changed the title
wazevo(amd64): encoding for div and signExtendData
wazevo(amd64): lower Fadd, Fsub, Fdiv, Fmul, Fsqrt; encode div, signExtendData
Jan 26, 2024
Signed-off-by: Edoardo Vacchi <evacchi@users.noreply.github.com>
evacchi
changed the title
wazevo(amd64): lower Fadd, Fsub, Fdiv, Fmul, Fsqrt; encode div, signExtendData
wazevo(amd64): lower Fabs, Fneg, Fadd, Fsub, Fdiv, Fmul, Fsqrt; encode div, signExtendData
Jan 26, 2024
Signed-off-by: Edoardo Vacchi <evacchi@users.noreply.github.com>
mathetake
reviewed
Jan 26, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
can you delete dev
and signExtendData
related change?
mathetake
changed the title
wazevo(amd64): lower Fabs, Fneg, Fadd, Fsub, Fdiv, Fmul, Fsqrt; encode div, signExtendData
wazevo(amd64): lower Fabs, Fneg, Fadd, Fsub, Fdiv, Fmul, Fsqrt
Jan 26, 2024
nvm, will do it myself. |
mathetake
approved these changes
Jan 26, 2024
mathetake
requested changes
Jan 26, 2024
Signed-off-by: Edoardo Vacchi <evacchi@users.noreply.github.com>
mathetake
reviewed
Jan 26, 2024
mathetake
reviewed
Jan 26, 2024
Signed-off-by: Edoardo Vacchi <evacchi@users.noreply.github.com>
sorry I will take over this. |
just so you know, the last three commits you made were unnecessarily made the code complex, and only you had to do was to fix the order of register. See 2a49278 |
mathetake
approved these changes
Jan 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Edoardo Vacchi evacchi@users.noreply.github.com