Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

internal: add tags and stubs so wazero can be compiled for MCU targets #2166

Merged
merged 2 commits into from
Mar 31, 2024

Conversation

deadprogram
Copy link
Contributor

@deadprogram deadprogram commented Mar 28, 2024

This PR modifies the internal/sock and internal/sysfs packages to add tags and stubs so Wazero can be compiled for MCU targets without operating systems. This is required for bare metal targets.

related issue: #1854

…s without operating systems

Signed-off-by: deadprogram <ron@hybridgroup.com>
Signed-off-by: deadprogram <ron@hybridgroup.com>
@deadprogram
Copy link
Contributor Author

Any feedback @evacchi or @mathetake ?

Copy link
Collaborator

@achille-roussel achille-roussel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The change looks good to me. Let's wait a couple days for Edo to double check and we can merge it 👍

Copy link
Contributor

@evacchi evacchi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks ok. Let's revisit this to consolidate all the recent changes

@evacchi evacchi merged commit 22e3861 into tetratelabs:main Mar 31, 2024
64 checks passed
@deadprogram deadprogram deleted the tinygo-build-tags-mcu branch March 31, 2024 09:32
@deadprogram
Copy link
Contributor Author

Thanks @evacchi

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants