Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

jit: support global get and set instructions #81

Merged
merged 33 commits into from
Dec 22, 2021
Merged

jit: support global get and set instructions #81

merged 33 commits into from
Dec 22, 2021

Conversation

mathetake
Copy link
Member

@mathetake mathetake commented Dec 22, 2021 •
edited
Loading

part of #65

@mathetake
setup
7a3a618 
Signed-off-by: Takeshi Yoneda <takeshi@tetrate.io>
@mathetake
support global.get
0b7cad3 
Signed-off-by: Takeshi Yoneda <takeshi@tetrate.io>
@mathetake
a
df1319f 
Signed-off-by: Takeshi Yoneda <takeshi@tetrate.io>
@mathetake
Merge remote-tracking branch 'origin/main' into jitglobals
d7c19dd
@mathetake
implement global.set
dabb8ae 
Signed-off-by: Takeshi Yoneda <takeshi@tetrate.io>
@mathetake
lint
885ec3e 
Signed-off-by: Takeshi Yoneda <takeshi@tetrate.io>
@mathetake mathetake marked this pull request as ready for review December 22, 2021 03:56
@mathetake mathetake mentioned this pull request Dec 22, 2021
Closed
@mathetake
more
5bc54af 
Signed-off-by: Takeshi Yoneda <takeshi@tetrate.io>
codefromthecrypt
codefromthecrypt approved these changes Dec 22, 2021
View reviewed changes
Copy link
Contributor

@codefromthecrypt codefromthecrypt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lots of pedantic things in the nit category. Don't let the fury of these suggest this change is anything but a great job!

wasm/jit/engine.go Outdated Show resolved Hide resolved
wasm/jit/engine.go Outdated Show resolved Hide resolved
wasm/jit/engine.go Show resolved Hide resolved
wasm/jit/jit_amd64.go Outdated Show resolved Hide resolved
wasm/jit/jit_amd64.go Outdated Show resolved Hide resolved
wasm/jit/jit_amd64_test.go Outdated Show resolved Hide resolved
wasm/jit/jit_amd64_test.go Outdated Show resolved Hide resolved
wasm/jit/jit_amd64_test.go Outdated Show resolved Hide resolved
wasm/jit/jit_amd64_test.go Outdated Show resolved Hide resolved
wasm/jit/jit_amd64_test.go Outdated Show resolved Hide resolved
mathetake and others added 19 commits December 22, 2021 14:21
@mathetake @codefromthecrypt
Update wasm/jit/engine.go
afb35bd 
Co-authored-by: Crypt Keeper <64215+codefromthecrypt@users.noreply.github.com>
@mathetake @codefromthecrypt
Update wasm/jit/engine.go
d847c18 
Co-authored-by: Crypt Keeper <64215+codefromthecrypt@users.noreply.github.com>
@mathetake @codefromthecrypt
Update wasm/jit/jit_amd64.go
437fb3b 
Co-authored-by: Crypt Keeper <64215+codefromthecrypt@users.noreply.github.com>
@mathetake @codefromthecrypt
Update wasm/jit/jit_amd64.go
ea69da8 
Co-authored-by: Crypt Keeper <64215+codefromthecrypt@users.noreply.github.com>
@mathetake @codefromthecrypt
Update wasm/jit/jit_amd64.go
1f36564 
Co-authored-by: Crypt Keeper <64215+codefromthecrypt@users.noreply.github.com>
@mathetake @codefromthecrypt
Update wasm/jit/engine.go
92974c8 
Co-authored-by: Crypt Keeper <64215+codefromthecrypt@users.noreply.github.com>
@mathetake @codefromthecrypt
Update wasm/jit/engine.go
7100503 
Co-authored-by: Crypt Keeper <64215+codefromthecrypt@users.noreply.github.com>
@mathetake @codefromthecrypt
Update wasm/jit/engine.go
bd9c028 
Co-authored-by: Crypt Keeper <64215+codefromthecrypt@users.noreply.github.com>
@mathetake @codefromthecrypt
Update wasm/jit/jit_amd64.go
0cbe9da 
Co-authored-by: Crypt Keeper <64215+codefromthecrypt@users.noreply.github.com>
@mathetake @codefromthecrypt
Update wasm/jit/jit_amd64.go
cab4338 
Co-authored-by: Crypt Keeper <64215+codefromthecrypt@users.noreply.github.com>
@mathetake @codefromthecrypt
Update wasm/jit/jit_amd64.go
c83f40a 
Co-authored-by: Crypt Keeper <64215+codefromthecrypt@users.noreply.github.com>
@mathetake @codefromthecrypt
Update wasm/jit/jit_amd64.go
9c0bf6e 
Co-authored-by: Crypt Keeper <64215+codefromthecrypt@users.noreply.github.com>
@mathetake @codefromthecrypt
Update wasm/jit/jit_amd64.go
4322da8 
Co-authored-by: Crypt Keeper <64215+codefromthecrypt@users.noreply.github.com>
@mathetake @codefromthecrypt
Update wasm/jit/jit_amd64.go
85f3ae6 
Co-authored-by: Crypt Keeper <64215+codefromthecrypt@users.noreply.github.com>
@mathetake @codefromthecrypt
Update wasm/jit/jit_amd64.go
2928a77 
Co-authored-by: Crypt Keeper <64215+codefromthecrypt@users.noreply.github.com>
@mathetake @codefromthecrypt
Update wasm/jit/jit_amd64.go
8299196 
Co-authored-by: Crypt Keeper <64215+codefromthecrypt@users.noreply.github.com>
@mathetake @codefromthecrypt
Update wasm/jit/jit_amd64.go
fa1481d 
Co-authored-by: Crypt Keeper <64215+codefromthecrypt@users.noreply.github.com>
@mathetake @codefromthecrypt
Update wasm/jit/jit_amd64.go
64c0496 
Co-authored-by: Crypt Keeper <64215+codefromthecrypt@users.noreply.github.com>
@mathetake @codefromthecrypt
Update wasm/jit/jit_amd64.go
436ba30 
Co-authored-by: Crypt Keeper <64215+codefromthecrypt@users.noreply.github.com>
mathetake and others added 7 commits December 22, 2021 14:24
@mathetake @codefromthecrypt
Update wasm/jit/jit_amd64_test.go
3470068 
Co-authored-by: Crypt Keeper <64215+codefromthecrypt@users.noreply.github.com>
@mathetake @codefromthecrypt
Update wasm/jit/jit_amd64_test.go
9aff671 
Co-authored-by: Crypt Keeper <64215+codefromthecrypt@users.noreply.github.com>
@mathetake @codefromthecrypt
Update wasm/jit/jit_amd64_test.go
21401b4 
Co-authored-by: Crypt Keeper <64215+codefromthecrypt@users.noreply.github.com>
@mathetake @codefromthecrypt
Update wasm/jit/jit_amd64_test.go
ebadae0 
Co-authored-by: Crypt Keeper <64215+codefromthecrypt@users.noreply.github.com>
@mathetake
drift
6b99aff 
Signed-off-by: Takeshi Yoneda <takeshi@tetrate.io>
@mathetake
reviews
41c8b72 
Signed-off-by: Takeshi Yoneda <takeshi@tetrate.io>
@mathetake
more comment
0e95082 
Signed-off-by: Takeshi Yoneda <takeshi@tetrate.io>
@mathetake mathetake merged commit adc4abe into main Dec 22, 2021
@mathetake mathetake deleted the jitglobals branch December 22, 2021 05:35
@mathetake
Copy link
Member Author

@codefromthecrypt thanks for the detailed reviews! Improved a lot :D

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@codefromthecrypt codefromthecrypt codefromthecrypt approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mathetake @codefromthecrypt