Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Establish ad colors and incorporate some data visuals colors #219

Merged
merged 3 commits into from
Jul 2, 2020

Conversation

ashley-hebler
Copy link
Member

What's this PR do?

Adds a new color variables and re-categorizes some of the ones we have

Variables added (if any)

(sorry these names are probably awful)

  • $color-white-off-light - For the ad placeholder
  • $color-ad-text - For the Become a member text
  • A whole bunch of data viz color vars

Why are we doing this? How does it help us?

It made sense to make our ad color rules variables so that we could use them in the data viz kit

Then I figured it might be cool to just document some of the colors in data viz land since they'll be using this framework soon. Maybe it's overkill 🤷‍♀️

How should this be manually tested?

npm run dev

See: Look at all the colors

Does this introduce a breaking change where queso-ui is used in the wild? If so, is there a relevant branch/PR to accompany this release?

Nah just a minor release

@ashley-hebler
Copy link
Member Author

@AndrewGibson27 @dxre-v3,
I'm going to merge this one bc it's mostly docs-related. I just wanted to give you a heads up.
Avriana, I don't think we need to add these to the slack bot, unless you want. You have the link to more colors in those, so ppl could click that to find the data viz colors.

@ashley-hebler ashley-hebler merged commit 9a0b914 into main Jul 2, 2020
@ashley-hebler ashley-hebler deleted the ad-colors branch July 7, 2020 13:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant