Establish ad colors and incorporate some data visuals colors #219
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's this PR do?
Adds a new color variables and re-categorizes some of the ones we have
Variables added (if any)
(sorry these names are probably awful)
$color-white-off-light
- For the ad placeholder$color-ad-text
- For the Become a member textWhy are we doing this? How does it help us?
It made sense to make our ad color rules variables so that we could use them in the data viz kit
Then I figured it might be cool to just document some of the colors in data viz land since they'll be using this framework soon. Maybe it's overkill 🤷♀️
How should this be manually tested?
npm run dev
See: Look at all the colors
Does this introduce a breaking change where queso-ui is used in the wild? If so, is there a relevant branch/PR to accompany this release?
Nah just a minor release