Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's this PR do?
Classes added (if any)
*These is the only ones that will actually show up in global CSS
Why are we doing this? How does it help us?
Accounts for styles in the Texas lawmakers directory and maybe some data visuals projects if these could also work for them.
How should this be manually tested?
npm run dev
I did some, "what do people tend to call these" research (added below) and
tag
seemed to be the most common. It also felt handy that both the name and how it's styled meant it could extend beyond just the use case of the R, D, labels. It is a loaded word for sure though, so I'm not married to it.border-radius: 50%
from the tag so that we could one day use it in other places.Does this introduce a breaking change where queso-ui is used in the wild? If so, is there a relevant branch/PR to accompany this release?
So far, no. I will need to go in and add
is-rounded-full
to the back to top button, but that feels like small 🥔 s.TODOs / next steps (probably in a new PR to keep this one small):
Scope out how lawmaker cards translate in the queso worldThese might make more sense at the repo level on second thought.Naming research