-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Flexbox helpers 💪 #765
Flexbox helpers 💪 #765
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks great! I will definitely make use of these!
I completely agree with not adding everything, though FWIW, I think one of my most used attributes is justify-content (start, end, center, space-X) 🚀
@djpeacher, yeah good point! Since flex-start is default and flex-end isn't referenced too, too often, I'll add one more for |
also adds helper for justify-content: space-between
@djpeacher, no rush on this, but what do you think about this new naming convention: Based on your note, I'm thinking this will be easier to add
P.S. one big smell of these is that we don't have responsive utilities so you can't alter layouts differently on mobile vs. desktop. I think we can use repo-specific CSS for that and in the way future we'd need to have some sort of pruning system for css in place for all the permutations there. While we're at it, maybe even one day migrate to tailwind 😄 |
This is useful for display: grid now also
display: grid is a little funny with space-between
@ashley-hebler haha yup, "AI" being a think now is a little unfortunate, but I think it's fine given the context! LGMT! 🚀 and yeah, having all the responsive utilities would be great one day! |
What's this PR do?
Adds some super basic flexbox classes
Classes added (if any)
Why are we doing this? How does it help us?
In theory, it will shave some lines from our current CSS
This may result in minimal bytes saved in the end, but hopefully helps us for future elements!
Why aren't there more?
I refrained from adding every utility one might need for flexbox and went with the ones I saw the most and that'd be most consistent. For instance a
gap:
helper would vary in what size value you want and other alignments likealign-items: flex-start
seem less frequentThis also shoots us in the foot a little in terms of naming if we got more
display grid
happy in the future.How should this be manually tested?
npm run dev
See:
/sections/layout/l-flex/
Does this introduce a breaking change where queso-ui is used in the wild? If so, is there a relevant branch/PR to accompany this release?
I'll tackle the texastribune PR (which is just a find and replace in HTML/CSS) when this is released. The new queso release won't hurt/change anything on its own.