Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixing single-instance not working with Qt5 ? #3747

Merged
merged 2 commits into from
Aug 5, 2024

Conversation

ysalmon
Copy link
Contributor

@ysalmon ysalmon commented Jul 29, 2024

For some reason, any of these two lines confuses the single-instance mechanism and makes TXS open each file in a new instance when invoked from the desktop environment on a file or via CLI texstudio somefile.tex.

I tried to say new QFileSystemModel() instead of new QFileSystemModel(this) on line 733, but to no avail.

(insert picture of dog in front a a keyboard with caption "I have no idea what I am doing")

Would fix #3743.

@sunderme
Copy link
Member

okay, your changes seem to work and look somewhat reasonable for a work-around

@ysalmon
Copy link
Contributor Author

ysalmon commented Jul 29, 2024

I should check if this is just /tmp or more generally files on different mountpoints. My current machine is impractical to test this, but in the next days I should be able to test on a machine where /opt is a mountpoint.

The underlying cause seems to be a bug in Qt. Maybe it is corrected in Qt6 ?

@ysalmon ysalmon marked this pull request as ready for review August 4, 2024 18:46
@sunderme sunderme merged commit 93b4e67 into texstudio-org:master Aug 5, 2024
7 checks passed
@sunderme
Copy link
Member

sunderme commented Aug 5, 2024

thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

TXS always opens file in new instances
2 participants