Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Buckets and Users APIs #117

Merged
merged 23 commits into from
Apr 30, 2020
Merged

Buckets and Users APIs #117

merged 23 commits into from
Apr 30, 2020

Conversation

carsonfarmer
Copy link
Member

No description provided.

@carsonfarmer
feat(hub): adding hub apis + context/credentials for managing headers
b536eef 
Signed-off-by: Carson Farmer <carson.farmer@gmail.com>
@carsonfarmer
feat(test): complete all hub tests
32d6a1d 
Signed-off-by: Carson Farmer <carson.farmer@gmail.com>
@carsonfarmer carsonfarmer added the enhancement New feature or request label Apr 28, 2020
@carsonfarmer carsonfarmer added this to the Sprint 35 milestone Apr 28, 2020
@carsonfarmer carsonfarmer self-assigned this Apr 28, 2020
@carsonfarmer
feat: buckets api wip [skip-ci]
5d85798 
Signed-off-by: Carson Farmer <carson.farmer@gmail.com>
@carsonfarmer
feat: update hub stuff (temp)
2efd708 
Signed-off-by: Carson Farmer <carson.farmer@gmail.com>
@carsonfarmer
feat: wip node + browser buckets tests [skip ci]
d3b42a8 
Signed-off-by: Carson Farmer <carson.farmer@gmail.com>
@carsonfarmer
feat: full feat and test coverage for buckets
7736e91 
Signed-off-by: Carson Farmer <carson.farmer@gmail.com>
@carsonfarmer
test: initial ci setup test push
c4c4e1f 
Signed-off-by: Carson Farmer <carson.farmer@gmail.com>
@carsonfarmer
chore: lint fixes
cd09d54 
Signed-off-by: Carson Farmer <carson.farmer@gmail.com>
@carsonfarmer
feat: update deps and finalize tests
5ce06f5 
Signed-off-by: Carson Farmer <carson.farmer@gmail.com>
github-actions[bot]
github-actions bot reviewed Apr 29, 2020
View reviewed changes
package-lock.json Show resolved Hide resolved
package-lock.json Show resolved Hide resolved
@carsonfarmer
test: try removing node tests for now
c8ecb0c 
Signed-off-by: Carson Farmer <carson.farmer@gmail.com>
@carsonfarmer
feat: create entry index file for browser pub
87a5dfe 
Signed-off-by: Carson Farmer <carson.farmer@gmail.com>
@carsonfarmer
fix: adds entry file
a9b2ba3 
Signed-off-by: Carson Farmer <carson.farmer@gmail.com>
@carsonfarmer
fix: case issue
a16d2dd 
Signed-off-by: Carson Farmer <carson.farmer@gmail.com>
@carsonfarmer
test: update ci image
3db4fe8 
Signed-off-by: Carson Farmer <carson.farmer@gmail.com>
@carsonfarmer
test: try to change session key
7d460fc 
Signed-off-by: Carson Farmer <carson.farmer@gmail.com>
@carsonfarmer
feat: update typedoc version
c91060f 
Signed-off-by: Carson Farmer <carson.farmer@gmail.com>
@carsonfarmer
test: adds back node tests
7d78381 
Signed-off-by: Carson Farmer <carson.farmer@gmail.com>
@carsonfarmer
test: moves node test down
2ded670 
Signed-off-by: Carson Farmer <carson.farmer@gmail.com>
@carsonfarmer
chore: remove hub module
8697326 
Signed-off-by: Carson Farmer <carson.farmer@gmail.com>
@carsonfarmer carsonfarmer marked this pull request as ready for review April 29, 2020 21:45
@carsonfarmer
Copy link
Member Author

Ok, @andrewxhill this is ready for a review. I've now removed the hub client code, and I'm using the latest docker image which mimics @jsign's local-up setup. This currently exports Context and Buckets from the main target. I'll branch off this PR and add the User APIs shortly as a separate PR.

@carsonfarmer
Copy link
Member Author

Note that we'll have to update the @textile/hub-grpc and @textile/buckets-grpc packages in this package once we officially release those.

carsonfarmer
carsonfarmer commented Apr 29, 2020
View reviewed changes
Copy link
Member Author

@carsonfarmer carsonfarmer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added some comments for you guys.

src/buckets.spec.ts Show resolved Hide resolved
src/buckets.spec.ts Show resolved Hide resolved
src/buckets.spec.ts Show resolved Hide resolved
src/buckets.ts Show resolved Hide resolved
src/buckets.ts Show resolved Hide resolved
src/buckets.ts Show resolved Hide resolved
src/buckets.ts Show resolved Hide resolved
src/normalize.ts Show resolved Hide resolved
src/context.ts Outdated Show resolved Hide resolved
src/buckets.spec.ts Outdated Show resolved Hide resolved
@carsonfarmer
feat: wip users api
a01205c 
Signed-off-by: Carson Farmer <carson.farmer@gmail.com>
@carsonfarmer
feat: 50% test coverage for user apis
9d2bcfe 
Signed-off-by: Carson Farmer <carson.farmer@gmail.com>
@carsonfarmer carsonfarmer changed the title WIP on Buckets API Buckets and Users APIs Apr 30, 2020
sanderpick
sanderpick approved these changes Apr 30, 2020
View reviewed changes
Copy link
Member

@sanderpick sanderpick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Whoa, awesome! LGTM, but I just gave it a skim for conceptual consistency... 💪

src/buckets.ts Show resolved Hide resolved
src/context.ts Show resolved Hide resolved
src/context.ts Show resolved Hide resolved
src/users.ts Show resolved Hide resolved
@carsonfarmer
feat: full contextualized developer buckets test
8388068 
Signed-off-by: Carson Farmer <carson.farmer@gmail.com>
@carsonfarmer
feat: completes all tests from go
ade9920 
Signed-off-by: Carson Farmer <carson.farmer@gmail.com>
@carsonfarmer carsonfarmer merged commit cf31c5a into master Apr 30, 2020
@carsonfarmer carsonfarmer deleted the carson/buckets branch April 30, 2020 23:56
This was referenced May 22, 2020
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@github-actions github-actions[bot] github-actions[bot] left review comments

@andrewxhill andrewxhill andrewxhill approved these changes

@sanderpick sanderpick sanderpick approved these changes

Assignees

@carsonfarmer carsonfarmer

Labels
enhancement New feature or request
Projects
None yet
Milestone
Sprint 35
Development

Successfully merging this pull request may close these issues.
3 participants
@carsonfarmer @sanderpick @andrewxhill