Files API #353

sanderpick · 2018-11-17T23:03:29Z

Still WIP but I want to start triggering CI. Mobile is coming together fast.

Includes required thread types, namely the account thread.

Mills are inspired by Transloadit robots, handling different files types described by the DAG node schemas.

This was causing the file to always get re-added since the checksum was different each time.

Still need to handle the write rejection, but wanted to get this in pre-migration.

One step can now use another via the "use" keyword.

Source is file/parent checksum + hash of mill opts. This allows for an additional pre-mill check for the file.

sanderpick · 2018-11-19T06:23:31Z

@carsonfarmer heads up, I created another field on file called opts (hash of opts), which used to be appended to source like source:opts... was a little weird... will be nice to be able to use source for actual queries with opts moved off to it's own. We can still check if a file has already been milled pre-mill by looking for existing files with mill, source, and opts all matching. There's a unique index compound index on those fields.

DOG FOOD

Set username and avatar, get own or others' profiles.

sanderpick · 2018-11-20T16:23:43Z

Added new gateway handling to resolve the new style avatars. The schema adds a small and large, which are accessible via /avatar/small, /avatar/large. Plain old /avatar falls back to /avatar/small.

sanderpick · 2018-11-20T16:26:15Z

new profile commands are:

$ textile profile get
$ textile profile set username <username>
$ textile profile set avatar <any image file hash, best results with a large or raw file from photos>

If this proves useful, we can clean up.

sanderpick · 2018-11-20T22:08:35Z

mobile/files.go

+}
+
+// PrepareFilesAsync is the async flavor of PrepareFiles
+func (m *Mobile) PrepareFilesAsync(path string, threadId string, cb Callback) {


@asutula I added an async version of PrepareFiles here which takes a callback interface. Let me know when you're around and we can talk through this and other changes.

sanderpick · 2018-11-20T22:11:35Z

ok guys, would like to get this merged. reviews requested!

carsonfarmer

whoah. this is huge. i've gone through everything with a medium-tooth comb. left mobile mostly for @asutula though. i've been playing with earlier versions of this, so seems stable enough to merge and start really kicking the tires...

cmd/files.go

cmd/invite.go

core/api.go

core/api_invites.go

core/main.go

core/thread.go

core/thread_invites.go

gateway/main.go

sanderpick added 30 commits November 6, 2018 11:19

feat(files): initial commite for files api

9850367

Includes required thread types, namely the account thread.

refactor(reposchemas): remove old (last?) OB legacy stuff

3b311fb

feat(schemas): initial commit for file and dag schemas

d0f54ef

feat(files): migrate thread service to files

5eedc2a

feat(schemas): wip on validate schemas

2182e8e

feat(files): wip thread add files command

3d87fc4

feat(files): wip building up files commands

0895317

feat(mills): initial commit for mill handling

be4e714

Mills are inspired by Transloadit robots, handling different files types described by the DAG node schemas.

feat(mills): schema mill for creating a new thread

721dfa2

feat(mills): add command working via milling schema

ad76b79

feat(files): share generated files to thread

58db418

feat(files): handle incoming files

e6385ac

feat(cmd): stub in thread invite cmd

25127fb

refactor(threads): add thread methods to thread service

70563e6

docs(comments): remove meaningless comments

93bbf41

style(goimports): switch from go fmt

12c77bd

fix(migrations): uncomment-out test file deletion

efa89bf

feat(invites): create and accept invite api

42cf8e7

feat(invites): adds ignore invite cmd

a50c42e

feat(files): list files command

61e37fc

feat(files): adds get file command

81a1c44

feat(files): adds pagination to files list cmd

dcc00d7

fix(files): inbound file handling

b2906bf

refactor(exif): remove added time

1645cde

This was causing the file to always get re-added since the checksum was different each time.

feat(threads): stubs in public and read-only thread type

15e1777

Still need to handle the write rejection, but wanted to get this in pre-migration.

feat(mill): adds step ordering

5ca511c

One step can now use another via the "use" keyword.

fix(files): parent is checksum

bc034c1

feat(files): adds source field to files for pre-check

a8ae9b2

Source is file/parent checksum + hash of mill opts. This allows for an additional pre-mill check for the file.

fix(files): opts not needed on mill result

9cd74d7

feat(files): replace parent with use in add file config

e0e2752

sanderpick added 7 commits November 19, 2018 10:52

refactor(mobile): adds comment, like, ignore mobile methods

4aaf7c7

refactor(mobile): adds more mobile, better thread file apis

a66fb1e

refactor(api): removes thread id requirement for files api

bfa0f36

Merge branch 'master' into sander/files

dd46725

refactor(avatars): refactor to use avatars schema

e59074d

DOG FOOD

feat(profile): adds profile get, set commands

dbe6165

Set username and avatar, get own or others' profiles.

feat(gateway): render new style avatars (plaintext)

e3de823

sanderpick added 3 commits November 20, 2018 12:28

refactor(mobile): adds back ImageFileDataForMinWidth

d30e505

test(mobile): adds back notification tests

5c5b3a1

feat(mobile): adds PrepareFilesAsync w/ proto

d3032bf

If this proves useful, we can clean up.

sanderpick commented Nov 20, 2018

View reviewed changes

sanderpick requested review from andrewxhill, asutula and carsonfarmer November 20, 2018 22:11

carsonfarmer approved these changes Nov 20, 2018

View reviewed changes

sanderpick added 2 commits November 20, 2018 17:17

refactor(api): check_mail -> messages

b33c70d

refactor(blockinfo): add username to block info

13e1b18

sanderpick merged commit d060920 into master Nov 21, 2018

sanderpick deleted the sander/files branch December 2, 2018 04:11

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Files API #353

Files API #353

sanderpick commented Nov 17, 2018

sanderpick commented Nov 19, 2018

sanderpick commented Nov 20, 2018 •

edited

Loading

sanderpick commented Nov 20, 2018 •

edited

Loading

sanderpick Nov 20, 2018

sanderpick commented Nov 20, 2018

carsonfarmer left a comment

Files API #353

Files API #353

Conversation

sanderpick commented Nov 17, 2018

sanderpick commented Nov 19, 2018

sanderpick commented Nov 20, 2018 • edited Loading

sanderpick commented Nov 20, 2018 • edited Loading

sanderpick Nov 20, 2018

Choose a reason for hiding this comment

sanderpick commented Nov 20, 2018

carsonfarmer left a comment

Choose a reason for hiding this comment

sanderpick commented Nov 20, 2018 •

edited

Loading

sanderpick commented Nov 20, 2018 •

edited

Loading