This repository has been archived by the owner on Mar 12, 2020. It is now read-only.
Adds messages and chat command #384
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Couldn't resist. Took a break from deploying. Will pick it up tomorrow. |
|
Check it out... threads chat, recovering from a member going offline. This feels like the culmination of the threads and cafe protocols.
|
carsonfarmer
approved these changes
Dec 5, 2018
| return nil | ||
| } | ||
|
|
||
| func callSub(threadId string, types []string) (<-chan core.ThreadUpdate, error) { |
There was a problem hiding this comment.
yeh this is nice, glad its proving useful outside of demos!
| @@ -132,6 +133,12 @@ func (a *api) Start() { | |||
| } | |||
| } | |||
|
|
|||
| messages := v0.Group("/messages") | |||
There was a problem hiding this comment.
this feels a bit weird having the two separate paths like this? not sure how else it should be done... is this pretty standard practice?
There was a problem hiding this comment.
yeah, agreed. same for files. my thought there was it's nice to be able to paginate across all files / messages... but maybe not needed. can revisit.
|
Cheers for the look @carsonfarmer ! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
messagesis likecommentswithout a target, added to top level of threadmessagesandsubcommands intochat💯