This repository has been archived by the owner on Mar 12, 2020. It is now read-only.
schemas: splits photos into two schemas #432
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sanderpick
commented
Dec 23, 2018
asutula
reviewed
Dec 23, 2018
asutula
reviewed
Dec 23, 2018
|
Ok, this should be good to go. When preparing files, you can pass an existing file hash as the file "path", which is what we'll want to do when sharing into a shared thread from camera roll. |
carsonfarmer
approved these changes
Dec 27, 2018
|
Reran pipeline, should be good to merge now 👍 |
|
Changes the schemas slightly to ensure that |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
camera_rollfor storage,mediafor photos (eventually other types that belong in a shared thread / chat / convo. For this to be app ready, I need to enable taking an existing hash (the blob file from thecamera_rollschema, and using it as the:filetag in themediaschema... all the handling is already there (it's the same as passing one step to another), but need a little tweak for directly setting the input.