SSL check when fetching version info in Diagnostics

Also added minumum OPENSSL constant and exposed the installed version in Low Diagnostics to aid debugging such issues.

Thanks, Adi.

textpattern/include/txp_diag.php

@@ -655,6 +655,8 @@ function doDiagnostics()
 
         gTxt('diag_php_sapi_mode').cs.PHP_SAPI.n,
 
+        gTxt('diag_ssl_version').cs.OPENSSL_VERSION_TEXT.n,
+
         gTxt('diag_rfc2616_headers').cs.ini_get('cgi.rfc2616_headers').n,
 
         gTxt('diag_server_os_version').cs.php_uname('s').' '.php_uname('r').n,
@@ -787,24 +789,6 @@ function checkUpdates()
 {
     $endpoint = 'https://textpattern.com/version.json';
     $release = $prerelease = null;
-
-    if (function_exists('curl_version')) {
-        $ch = curl_init($endpoint);
-        curl_setopt($ch, CURLOPT_RETURNTRANSFER, true);
-        $contents = curl_exec($ch);
-    } else {
-        $contents = file_get_contents($endpoint);
-    }
-
-    $response = @json_decode($contents, true);
-
-    if (isset($response['textpattern-version'])) {
-        $release = $response['textpattern-version']['release'];
-        $prerelease = $response['textpattern-version']['prerelease'];
-    }
-
-    $version = get_pref('version');
-
     $lastCheck = array(
         'when'     => time(),
         'msg'      => '',
@@ -814,20 +798,41 @@ function checkUpdates()
         'response' => true,
     );
 
-    if (!empty($release)) {
-        if (version_compare($version, $release) < 0) {
-            $lastCheck['msg'] = 'textpattern_update_available';
-            $lastCheck['msgval'] = array('{version}' => $release);
+    if (OPENSSL_VERSION_NUMBER < REQUIRED_OPENSSL_VERSION) {
+        $lastCheck['msg'] = 'problem_connecting_update_server';
+        $lastCheck['response'] = false;
+    } else {
+        if (function_exists('curl_version')) {
+            $ch = curl_init($endpoint);
+            curl_setopt($ch, CURLOPT_RETURNTRANSFER, true);
+            $contents = curl_exec($ch);
+        } else {
+            $contents = file_get_contents($endpoint);
+        }
+
+        $response = @json_decode($contents, true);
+
+        if (isset($response['textpattern-version'])) {
+            $release = $response['textpattern-version']['release'];
+            $prerelease = $response['textpattern-version']['prerelease'];
         }
 
-        if (version_compare($version, $prerelease) < 0) {
-            $lastCheck['msg2'] = 'textpattern_update_available_beta';
-            $lastCheck['msgval2'] = array('{version}' => $prerelease);
+        $version = get_pref('version');
+
+        if (!empty($release)) {
+            if (version_compare($version, $release) < 0) {
+                $lastCheck['msg'] = 'textpattern_update_available';
+                $lastCheck['msgval'] = array('{version}' => $release);
+            }
+
+            if (version_compare($version, $prerelease) < 0) {
+                $lastCheck['msg2'] = 'textpattern_update_available_beta';
+                $lastCheck['msgval2'] = array('{version}' => $prerelease);
+            }
+        } else {
+            $lastCheck['msg'] = 'problem_connecting_update_server';
+            $lastCheck['response'] = false;
         }
-    } else {
-        $lastCheck['msg'] = 'problem_connecting_update_server';
-        $lastCheck['msgval'] = array();
-        $lastCheck['response'] = false;
     }
 
     set_pref('last_update_check', json_encode($lastCheck, TEXTPATTERN_JSON), 'publish', PREF_HIDDEN, 'text_input');

textpattern/lib/constants.php

@@ -698,6 +698,17 @@
 
 define('REQUIRED_PHP_VERSION', '5.5.0');
 
+/**
+ * Required OPENSSL version.
+ *
+ * Used when fetching resources via file_get_contents() or cURL.
+ *
+ * @since   4.8.5
+ * @package System
+ */
+
+define('REQUIRED_OPENSSL_VERSION', '268439567');
+
 /**
  * File integrity status good.
  *

textpattern/mode.ini

@@ -90,6 +90,7 @@ diag_rfc2616_headers="RFC 2616 headers"
 diag_server_os_version="Server OS"
 diag_server_time="Server local time"
 diag_server_timezone="Server timezone"
+diag_ssl_version="SSL version"
 diag_tempdir="Temporary directory path"
 diag_theme_name="Admin-side theme"
 diag_txp_path="Textpattern path"