Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Header icon broken since 0.61.0 #4534

Closed
panki27 opened this issue May 21, 2024 · 4 comments
Closed

Header icon broken since 0.61.0 #4534

panki27 opened this issue May 21, 2024 · 4 comments

Comments

@panki27
Copy link

panki27 commented May 21, 2024

As already reported in Discord: since upgrading to textual==0.61.0, clicking the header icon does no longer open the command palette.
The palette can still be summoned by hitting the keyboard shortcut.

MRE:

from textual import __version__
from textual.app import App, ComposeResult
from textual.widgets import Label, Header

class CommandPaletteApp(App[None]):

    def compose(self) -> ComposeResult:
        yield Header()
        yield Label(f"This is Textual v{__version__}")

if __name__ == "__main__":
    CommandPaletteApp().run()

Clicking the header icon with the mouse results in the following message being logged:

<action> 'command_palette' has no target. Could not find methods '_action_command_palette' or 'action_command_palette'

Darren and Dave were able to narrow it down do this line of code:

await self.run_action("command_palette")

That should now be:

await self.run_action("app.command_palette")
Copy link

We found the following entry in the FAQ which you may find helpful:

Feel free to close this issue if you found an answer in the FAQ. Otherwise, please give us a little time to review.

This is an automated reply, generated by FAQtory

@TomJGooding
Copy link
Contributor

TIL that clicking the header icon will open the command pallette.

@willmcgugan
Copy link
Collaborator

Fixed in 0.63.0

Copy link

Don't forget to star the repository!

Follow @textualizeio for Textual updates.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants