Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Handle SSO Logics #128

Merged
merged 6 commits into from
Dec 28, 2023
Merged

Handle SSO Logics #128

merged 6 commits into from
Dec 28, 2023

Conversation

KimangKhenng
Copy link
Collaborator

  • Add nuxt auth strategies (Github, Facebook, Google)
  • Add integration page to ask user to login with existing service
  • Fallback logic in axios

@KimangKhenng KimangKhenng self-assigned this Dec 28, 2023
@KimangKhenng KimangKhenng added the enhancement New feature or request label Dec 28, 2023
tfd-ed
tfd-ed reviewed Dec 28, 2023
View reviewed changes
middleware/check-params.js Outdated Show resolved Hide resolved
@KimangKhenng KimangKhenng linked an issue Dec 28, 2023 that may be closed by this pull request
SSO Logic to communicate with backend #126
Closed
@KimangKhenng @tfd-ed
Update middleware/check-params.js
1500f03 
Co-authored-by: tfd-ed <info@tfdevs.com>
tfd-ed
tfd-ed requested changes Dec 28, 2023
View reviewed changes
Copy link
Owner

@tfd-ed tfd-ed left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Here is my suggestions!

pages/login.vue Outdated Show resolved Hide resolved
plugins/vuex-persist.client.js Show resolved Hide resolved
@KimangKhenng @tfd-ed
Update pages/login.vue
26a60aa 
Remove empty script

Co-authored-by: tfd-ed <info@tfdevs.com>
tfd-ed
tfd-ed approved these changes Dec 28, 2023
View reviewed changes
Copy link
Owner

@tfd-ed tfd-ed left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@KimangKhenng KimangKhenng merged commit 794e544 into tfd-ed:features/Handle-SSO Dec 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tfd-ed tfd-ed tfd-ed approved these changes

Assignees

@KimangKhenng KimangKhenng

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

SSO Logic to communicate with backend
2 participants
@KimangKhenng @tfd-ed