File Content Filter Unusable With Multiline Text

[zor-el]

Typical real-world use cases for a content filter involve multiple matches and regex captures spread over several lines of text. Alas, the current implementation only works if the entire filter expression is contained within a single line. ^1,2

Tested with version 1.8.0 and HEAD.

I will be posting a PR that fixes this in a few minutes.

BTW, love this tool. :)

---

¹⁾ This is not so surprising. A look at the corresponding test revealed only the most trivial cases are covered. (The aside here being: Perhaps review the tests to cover more realistic scenarios. ;-))

²⁾ Note that using more than one file content filter per rule is currently not an acceptable workaround, b/c the way the FileContent filter is implemented, it involves redundant textract processing and severe performance penalties when used multiple times per rule, particularly for formats other than plain text, ex. PDF. (This is worth rethinking in its own right, but not the subject of this issue.)