-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Updating master to 1.0.0 #22
Conversation
* WIP for Jake to review if can before he leaves * Significant refactoring greatly improves the architecture for adding new commands - All previous functionality temporarily stripped out with the exception of "build static" - Original functionality to be re-introduced feature by feature
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking forward to working with this new overall structure, I am sure I'll have more feedback once I have started making updates.
@@ -1,25 +1,14 @@ | |||
{ | |||
"name": "@tforster/joy", | |||
"version": "0.3.3", | |||
"version": "1.0.0", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's discuss how we want to manage versioning and when to update to 1.0.0
.on('end', resolve); | ||
}); | ||
}) | ||
); | ||
} | ||
|
||
|
||
// TODO: Figure out why this code throws a PluginError |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I will look at replacing some of this with the custom gulp logic I have been improving on in the past.
this.config = joy.config; | ||
this.stage = args.flags.stage.value; | ||
|
||
// ! HACK: Had to tack stage on to renderData to get Jake's to work. Needs elegance++ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's chat about this during our next catchup on Joy.
|
||
tbd | ||
v1.0.0 **Breaking Refactor** (2019-09-13) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Perhaps a more descriptive name of the nature of the refactor.
* New architecture! (#13) * WIP for Jake to review if can before he leaves * Significant refactoring greatly improves the architecture for adding new commands - All previous functionality temporarily stripped out with the exception of "build static" - Original functionality to be re-introduced feature by feature * Added vendor folder to list of folders to copy to target (#14)
* New architecture! (#13) * WIP for Jake to review if can before he leaves * Significant refactoring greatly improves the architecture for adding new commands - All previous functionality temporarily stripped out with the exception of "build static" - Original functionality to be re-introduced feature by feature * Added vendor folder to list of folders to copy to target (#14)
No description provided.