Update lodash from 3.7.0 -> 4.6.0 #1242
Conversation
|
Sorry, it looks like my IDE went apeshit on the indentation.. I'll fix this. |
|
👍 great work @wubzz! Since this is such an integral dependency I agree it would be wise to bump at least the minor version. |
|
@wubzz looks good, but need to resolve conflict before being able to merge |
|
@elhigu Yeah, no problem, I'll resolve those. Though, I'm not sure if we want to merge this already or not. I'm thinking 0.11 to be safe. |
|
If we merge this now, next knex release will be 0.11 :) On the other hand if we haven't made any breaking changes since 0.10 we could roll out 0.10.1 already. EDIT: actually there seem to be breaking changes already introduced after 0.10 e.g. 942877c |
|
@wubzz next release will be 0.11 so no need to be on hold with this |
|
@elhigu Sweet, I'll get this done sometime this week. Do you think Upgrading Bluebird would be appropiate at the same time? There's an issue for this too. (Seperate PR, of course) |
wubzz
force-pushed
the
update_lodash_dependency
branch
from
0801997
to
3b7070f
Compare
Update lodash from 3.7.0 -> 4.6.0
Fixes #1214 . Updates lodash to v4, which affects more or less all project files. I would only include this PR for a big release, even if tests pass.