-
Notifications
You must be signed in to change notification settings - Fork 820
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Examine shows the wrong icon. #494
Comments
@spookydonut No idea why this happens, couldn't get it working even with costly_bicon |
ohhhhhhhh uh give me a few days to remember why this happens |
I made /tg/'s current bicon, are we using that, or the ones that came with goonchat? |
I think we're using /vg/'s |
Moving to /tg/'s bicon would be better, /vg/'s one also locks up the chat because the client has to decode a base64's icon string embedded in the html, and the same icon can be sent repeatedly. /tg/'s one uses passive sending and loading the assets up to the client's html temp folder so they can be embedded as normal web images, and it (and the asset cache system) keeps track of what the client's been sent, so they don't have to get the same icon twice. |
Fixed in #659 |
* Added ban reason and r_id modified: code/modules/admin/panels/ban_panel.dm * Adminlog r_id added modified: code/modules/admin/verbs/adminhelp.dm modified: code/modules/mob/living/living_helpers.dm * modified: code/modules/mob/living/living_helpers.dm
Testmerges:
#123 #480 #482 #485 #474 #320 #453 #459 #464 #451 #367 #439 #440 #447 #465 #468 #469 #488 #479 #478 #457
Reproduction:
Examine shows the wrong icon.
The text was updated successfully, but these errors were encountered: