Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Examine shows the wrong icon. #494

Closed
Rohesie opened this issue Feb 2, 2019 · 6 comments
Closed

Examine shows the wrong icon. #494

Rohesie opened this issue Feb 2, 2019 · 6 comments
Labels
Bug Incorrect functionality.

Comments

@Rohesie
Copy link
Member

Rohesie commented Feb 2, 2019

Testmerges:

#123 #480 #482 #485 #474 #320 #453 #459 #464 #451 #367 #439 #440 #447 #465 #468 #469 #488 #479 #478 #457

Reproduction:

sleeps

Examine shows the wrong icon.

@A-lexa
Copy link
Contributor

A-lexa commented Feb 2, 2019

@spookydonut No idea why this happens, couldn't get it working even with costly_bicon

@spookydonut
Copy link
Contributor

ohhhhhhhh uh give me a few days to remember why this happens

@MrStonedOne
Copy link
Member

I made /tg/'s current bicon, are we using that, or the ones that came with goonchat?

@A-lexa
Copy link
Contributor

A-lexa commented Feb 3, 2019

I think we're using /vg/'s

@Rohesie Rohesie added the Bug Incorrect functionality. label Feb 3, 2019
@MrStonedOne
Copy link
Member

MrStonedOne commented Feb 4, 2019

Moving to /tg/'s bicon would be better, /vg/'s one also locks up the chat because the client has to decode a base64's icon string embedded in the html, and the same icon can be sent repeatedly. /tg/'s one uses passive sending and loading the assets up to the client's html temp folder so they can be embedded as normal web images, and it (and the asset cache system) keeps track of what the client's been sent, so they don't have to get the same icon twice.

@A-lexa
Copy link
Contributor

A-lexa commented Feb 13, 2019

Fixed in #659

@A-lexa A-lexa closed this as completed Feb 13, 2019
fe-ed pushed a commit to fe-ed/Incitatus-Fork that referenced this issue Mar 21, 2024
* Added ban reason and r_id
	modified:   code/modules/admin/panels/ban_panel.dm

* Adminlog r_id added
	modified:   code/modules/admin/verbs/adminhelp.dm
	modified:   code/modules/mob/living/living_helpers.dm

* modified:   code/modules/mob/living/living_helpers.dm
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Incorrect functionality.
Projects
None yet
Development

No branches or pull requests

4 participants