Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Gives supply beacons on the minimap the req background colour and a red tip #16271

Merged
merged 1 commit into from
Jul 9, 2024

Conversation

Ldip999
Copy link
Contributor

@Ldip999 Ldip999 commented Jul 5, 2024

About The Pull Request

Makes the background of the supply beacons a "requsitionesq" brown on the map.

Why It's Good For The Game

Supply beacons are currently hard to find as they are easily confused since they look like rotated sentries, and otherwise have a plain, dark grey background, which helps them blend into the background. This PR attempts to remedy it by making them stand out more by giving them a brown background and a red flashing tip on the minimap

Before:
image
After:
image
(Sentries added to futher illustrate my point of how easily these get lost nearby other markers)

Changelog

🆑
qol: Supply beacons on the maps now have a brown background and a red flashing tip, hopefully making them easier to see.
/:cl:

@tgstation-server tgstation-server added Sprites Changes to .dmi file. Quality of Life Minor changes that make the game nicer to play labels Jul 5, 2024
@DrAmazing343
Copy link

absolute king shit ur a hero to dirty reqqies like me

@Wisemonster
Copy link
Contributor

An image comparing the new sprite to the old sprite would be nice

@Ldip999
Copy link
Contributor Author

Ldip999 commented Jul 6, 2024

An image comparing the new sprite to the old sprite would be nice

Done

@grinkgo
Copy link
Contributor

grinkgo commented Jul 6, 2024

is this the way i find out req beacons had a mini-map icon...

@github-actions github-actions bot added the Merge Conflict Pull request is in a conflicted state with base branch. label Jul 7, 2024
@Ldip999 Ldip999 closed this Jul 7, 2024
@Ldip999 Ldip999 reopened this Jul 7, 2024
@tgstation-server tgstation-server removed the Merge Conflict Pull request is in a conflicted state with base branch. label Jul 7, 2024
@Ldip999
Copy link
Contributor Author

Ldip999 commented Jul 7, 2024

is this the way i find out req beacons had a mini-map icon...

That makes two 😀
At first I thought they were just rotated sentries, hence my initial confusion. When I first set out with this PR, I wanted to ADD a supply beacon to the minimap only to find out halfway it was already a thing that got lost in the sea of other stuff

@lbnesquik
Copy link
Contributor

Now, I am not asking Ldip999 to do it for us, but I think at some point, we'll need some minimap options, because we honestly are starting to get a little too cluttered in terms of icons, especially with Tad, APC, Tank, Leaders and all the other stuff.

@Lumipharon Lumipharon merged commit ac86dec into tgstation:master Jul 9, 2024
41 of 43 checks passed
github-actions bot added a commit that referenced this pull request Jul 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Quality of Life Minor changes that make the game nicer to play Sprites Changes to .dmi file.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants