Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Imager Goggles #7312

Merged
merged 6 commits into from
Jul 15, 2021
Merged

Imager Goggles #7312

merged 6 commits into from
Jul 15, 2021

Conversation

EvilMelonTheSecond
Copy link
Contributor

@EvilMelonTheSecond EvilMelonTheSecond commented Jul 8, 2021

About The Pull Request

An alternative to mesons. Req only. Name, price and icon are open to discussion.

Why It's Good For The Game

I really like the pseudo nightvision properties of meson but it seems others disagree for various reasons. Now its a req item with nothing but the light alpha adjustment. I believe this is a much better alternative than adding night vision to marines and should stay in the game.
A terribly cropped image for clarity.
imaging

This PR is intended to be implemented with either #7306 or #7307

Changelog

🆑
expansion: Added meson-like goggles to req
/:cl:

An alternative to mesons. Req only
@tgstation-server tgstation-server added the Content Expansion The code was designed to handle this label Jul 8, 2021
@BraveMole
Copy link
Contributor

I'm fine with this, but then remove mesons from vendors and maps

@EvilMelonTheSecond
Copy link
Contributor Author

I'm fine with this, but then remove mesons from vendors and maps

I forgot to mention the removal PR's it seems. I'll edit the description

@InterroLouis
Copy link
Contributor

This would just have the same problem as mesons but without revealing turfs, wouldn't it?

EvilMelonTheSecond and others added 3 commits July 10, 2021 02:12
Co-authored-by: Pariah919 <46353991+Pariah919@users.noreply.github.com>
@SpaceLoveSs13
Copy link
Contributor

Why? Mesons already got their intended change with #7307. No need for it to be req only now.

@EvilMelonTheSecond
Copy link
Contributor Author

Why? Mesons already got their intended change with #7307. No need for it to be req only now.

The intention is to preserve that mechanic by making it an independent tool with no other property and slapping a price tag on it.

code/modules/clothing/glasses/night.dm Outdated Show resolved Hide resolved
code/modules/reqs/supplypacks.dm Outdated Show resolved Hide resolved
Copy link
Contributor Author

@EvilMelonTheSecond EvilMelonTheSecond left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cost reverted back to 5 points. toggleable var changed to bool (Despite other objects in the same file not using bool)

@David-Stormwell
Copy link
Contributor

Can you post an image on the PR of how these work?

@SplinterGP
Copy link
Member

SplinterGP commented Jul 13, 2021

Can you post an image on the PR of how these work?

they work like mesons did before we changed it, but without showing behind walls.

@EvilMelonTheSecond
Copy link
Contributor Author

EvilMelonTheSecond commented Jul 13, 2021

Can you post an image on the PR of how these work?

Added an image comparing the item with normal vision

@BraveMole
Copy link
Contributor

Why not proposing "costly" nvg goggles ?

Copy link
Member

@SplinterGP SplinterGP left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code fine

@SilencedMP5A5
Copy link
Contributor

literally just re-add nvg's from cool req

@TiviPlus
Copy link
Member

literally just re-add nvg's from cool req

No

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Content Expansion The code was designed to handle this
Projects
None yet
Development

Successfully merging this pull request may close these issues.

10 participants