Automatic UAC evaluation for Tgstation.Server.Host.exe #1566
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Creates a separate resource manifest for the Tgstation.Server.Host.exe so that the process will automatically elevate to the user's highest permission when ran. Shows a warning to the user and triggers UAC.
|
Thank you for contributing to tgstation-server! As this pull request is from a fork, we can't allow the CI actions which require repository secrets to run on it without approval. After a brief review to make sure you're not misusing those secrets, a maintainer will add the |
Cyberboss
requested changes
Jun 21, 2023
Cyberboss
added
Feature
Cyberboss
added
Code Improvement
Cyberboss
approved these changes
Jun 21, 2023
Codecov Report
@@ Coverage Diff @@
## master #1566 +/- ##
==========================================
+ Coverage 72.80% 72.86% +0.05%
==========================================
Files 352 352
Lines 21925 21925
==========================================
+ Hits 15963 15976 +13
+ Misses 5962 5949 -13 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Creates a separate resource manifest for the Tgstation.Server.Host.exe so that the process will automatically elevate to the user's highest permission when ran. Shows a warning to the user and triggers UAC.
🆑
On Windows, TGS will request administrator privileges when needed.
/:cl:
Automatic elevation of executable file will prompt UAC even when running on release, this prevents exceptions and errors from occurring because of an improperly configured manifest. Errors will persist if user fails to provide sufficient permissions.