Fixed phantom slipping caused by mk-clown shoes bananas #60626
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tgstation-server
added
the
Fix
Kylerace
requested changes
Aug 2, 2021
tgstation-server
added a commit
that referenced
this pull request
Aug 2, 2021
LemonInTheDark
pushed a commit
to LemonInTheDark/tgstation
that referenced
this pull request
Dec 12, 2021
…tation#57) * Fixed phantom slipping caused by mk-clown shoes bananas (tgstation#60626) Co-authored-by: Watermelon914 <3052169-Watermelon914@ users.noreply.gitlab.com> * Fixed phantom slipping caused by mk-clown shoes bananas Co-authored-by: Watermelon914 <37270891+Watermelon914@users.noreply.github.com> Co-authored-by: Watermelon914 <3052169-Watermelon914@ users.noreply.gitlab.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
About The Pull Request
Closes #59410
Synthesized banana peels would make a new /datum/component/slippery, and because it was highlander, it would fuck up due to some issues with the cleanup code for the old /datum/component/slipper component running after the new component had already set up their code.
The solution was this was to move the component to have the COMPONENT_DUPE_UNIQUE_PASSARGS dupe_mode.
Why It's Good For The Game
Bugfixes be good
Changelog
🆑
fix: Fixed phantom slipping caused by synthesized banana peels.
/:cl: