Fix lyrics genius missing parts #671
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…b.com/Araxeus/youtube-music into lyrics]-fix-part-of-lyrics-is-missing
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously lyrics would come from
querySelector('[class^="Lyrics__Container"]'), but genius sometimes have multiple lyrics div's for the same song, for example https://genius.com/Built-to-spill-velvet-waltz-lyricsthis PR change the lyrics to come from querySelectorAll and join their inner html with
<br>fix #664
notes:
lyricsSelector1 = Array.from(querySelectorAll(...))....join(...)is safe sincequerySelectorAllreturns an emptyNodeListif none are foundArray.from(EmptyNodeList)returns an empty array (switched to spread syntax but same behavior)EmptyArray.join(..)returns empty stringcommit history is messy and should be squashed