Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Prometheus #8

Merged
merged 23 commits into from
Feb 22, 2023
Merged

Prometheus #8

merged 23 commits into from
Feb 22, 2023

Conversation

butbaiak
Copy link
Contributor

@butbaiak butbaiak commented Feb 5, 2023

No description provided.

Nikita-Smirnov-Exactpro
Nikita-Smirnov-Exactpro requested changes Feb 7, 2023
View reviewed changes
schema/factory/CommonFactory.go Outdated Show resolved Hide resolved
schema/metrics/CommonMetrics.go Outdated Show resolved Hide resolved
schema/metrics/AggregatingMetric.go Outdated Show resolved Hide resolved
@Nikita-Smirnov-Exactpro
Copy link
Member

@butbaiak, will be good if you add some base metrics from the spreadsheet into other module:
https://docs.google.com/spreadsheets/d/1RUJoTxllMKqE47hDqzweQTxzZrv5c4uGMQN3rUXkfTc/edit#gid=286964867

th2_rabbitmq_message_size_publish_bytes
th2_rabbitmq_message_publish_total
th2_rabbitmq_message_size_subscribe_bytes
th2_rabbitmq_message_process_duration_seconds

th2_message_publish_total
th2_message_subscribe_total

th2_message_group_publish_total
th2_message_group_subscribe_total

th2_event_publish_total
th2_event_subscribe_total

Nikita-Smirnov-Exactpro
Nikita-Smirnov-Exactpro requested changes Feb 9, 2023
View reviewed changes
schema/metrics/AggregatingMetric.go Outdated Show resolved Hide resolved
schema/queue/message/impl/RabbitMqMessageSender.go Outdated Show resolved Hide resolved
schema/queue/message/impl/RabbitMqMessageSubscriber.go Outdated Show resolved Hide resolved
Nikita-Smirnov-Exactpro
Nikita-Smirnov-Exactpro reviewed Feb 13, 2023
View reviewed changes
schema/metrics/FlagArbiter.go Outdated Show resolved Hide resolved
schema/metrics/MetricFlag.go Outdated Show resolved Hide resolved
schema/modules/PrometheusModule/PrometheusModule.go Outdated Show resolved Hide resolved
Nikita-Smirnov-Exactpro
Nikita-Smirnov-Exactpro requested changes Feb 14, 2023
View reviewed changes
schema/queue/event/impl/MqEventSender.go Outdated Show resolved Hide resolved
schema/queue/event/impl/MqEventSubscriber.go Outdated Show resolved Hide resolved
schema/queue/message/impl/RabbitMqMessageSender.go Outdated Show resolved Hide resolved
schema/queue/message/impl/RabbitMqMessageSubscriber.go Outdated Show resolved Hide resolved
schema/queue/message/impl/RabbitMqMessageSubscriber.go Outdated Show resolved Hide resolved
@Nikita-Smirnov-Exactpro Nikita-Smirnov-Exactpro changed the base branch from master to env-variable February 14, 2023 12:05
Nikita-Smirnov-Exactpro
Nikita-Smirnov-Exactpro requested changes Feb 14, 2023
View reviewed changes
schema/queue/event/impl/MqEventSender.go Outdated Show resolved Hide resolved
schema/queue/event/impl/MqEventSubscriber.go Outdated Show resolved Hide resolved
schema/queue/message/impl/RabbitMqMessageSender.go Outdated Show resolved Hide resolved
Nikita-Smirnov-Exactpro
Nikita-Smirnov-Exactpro requested changes Feb 16, 2023
View reviewed changes
Copy link
Member

@Nikita-Smirnov-Exactpro Nikita-Smirnov-Exactpro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Implement metrics
th2_message_publish_total
th2_message_subscribe_total

schema/queue/MQcommon/Consumer.go Outdated Show resolved Hide resolved
schema/queue/event/impl/MqEventSender.go Outdated Show resolved Hide resolved
schema/queue/message/impl/RabbitMqMessageSender.go Outdated Show resolved Hide resolved
@Nikita-Smirnov-Exactpro Nikita-Smirnov-Exactpro merged commit c005f5c into env-variable Feb 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Nikita-Smirnov-Exactpro Nikita-Smirnov-Exactpro Nikita-Smirnov-Exactpro approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@butbaiak @Nikita-Smirnov-Exactpro