[TH2-4559] Migration to processor-core #3
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@isengrims @OptimumOpium we need a separate target branch related to book and page, for example |
Nikita-Smirnov-Exactpro
requested changes
Feb 2, 2023
sense-app/src/main/kotlin/com/exactpro/th2/sense/app/Microservice.kt
Outdated
Show resolved
Hide resolved
sense-app/src/main/kotlin/com/exactpro/th2/sense/app/cfg/ProcessorConfiguration.kt
Outdated
Show resolved
Hide resolved
Nikita-Smirnov-Exactpro
requested changes
Feb 3, 2023
| @AutoService(IProcessorFactory::class) | ||
| class SenseProcessorFactory : IProcessorFactory { | ||
| private val processorProvider = ServiceLoaderProcessorProvider.create<EventProcessor, EventProcessorFactory<*>>() | ||
| private val resources: Deque<() -> Unit> = ConcurrentLinkedDeque() |
There was a problem hiding this comment.
It is redundant queue, because the factory doesn't control resources. Processor should close all resources on Close method call
There was a problem hiding this comment.
Please remove unused variable
sense-app/src/main/kotlin/com/exactpro/th2/sense/app/source/processor/SenseProcessorFactory.kt
Outdated
Show resolved
Hide resolved
OptimumCode
reviewed
Feb 3, 2023
sense-app/src/main/kotlin/com/exactpro/th2/sense/app/source/processor/SenseProcessor.kt
Outdated
Show resolved
Hide resolved
sense-app/src/main/kotlin/com/exactpro/th2/sense/app/source/processor/SenseProcessor.kt
Outdated
Show resolved
Hide resolved
sense-app/src/main/kotlin/com/exactpro/th2/sense/app/source/processor/SenseProcessorFactory.kt
Outdated
Show resolved
Hide resolved
Nikita-Smirnov-Exactpro
approved these changes
Feb 7, 2023
OptimumCode
approved these changes
Feb 7, 2023
| @@ -1,5 +1,5 @@ | |||
| /* | |||
| * Copyright 2022 Exactpro (Exactpro Systems Limited) | |||
| * Copyright 2023-2023 Exactpro (Exactpro Systems Limited) | |||
There was a problem hiding this comment.
Should be either 2022-2023 or just 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.