split to subprojects, core and test utils #28
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Nikita-Smirnov-Exactpro
requested changes
Nov 19, 2021
sim-test-utils/src/main/kotlin/com/exactpro/th2/sim/template/rule/test/api/TestRuleContext.kt
Show resolved
Hide resolved
| import java.util.concurrent.ScheduledExecutorService | ||
| import java.util.concurrent.TimeUnit | ||
|
|
||
| class TestRuleContext : IRuleContext { |
There was a problem hiding this comment.
Could we use the mockito library instead?
|
|
||
| fun assertEqualsMessages(expected: Message, actual: Message, lazyMessage: () -> String? = {null}) { | ||
| val assertExpected = expected.toBuilder().apply { | ||
| metadataBuilder.timestampBuilder.resetTimestamp() |
There was a problem hiding this comment.
Maybe set the Timestamp.getDefaultInstance() instead of custom method to resetTimestamp
There was a problem hiding this comment.
isn't result of this will be same, default timestamp gonna set time of creation point and we just gonna set both messages to same link of timestamp. Current realization seting both of them to same point too but zeroes.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.