Skip to content

Commit

Permalink
oci: WithDefaultUnixDevices(): remove tun/tap from the default devices
Browse files Browse the repository at this point in the history
A container should not have access to tun/tap device, unless it is explicitly
specified in configuration.

This device was already removed from docker's default, and runc's default;

- opencontainers/runc@2ce40b6
- https://github.com/moby/moby//commit/9c4570a958df42d1ad19364b1a8da55b891d850a

Per the commit message in runc, this should also fix these messages;

> Apr 26 03:46:56 foo.bar systemd[1]: Couldn't stat device /dev/char/10:200: No such file or directory

coming from systemd on every container start, when the systemd cgroup driver
is used, and the system runs an old (< v240) version of systemd
(the message was presumably eliminated by [1]).

[1]: systemd/systemd@d5aecba

Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
  • Loading branch information
thaJeztah committed May 10, 2022
1 parent 6067aeb commit a3ac156
Showing 1 changed file with 1 addition and 8 deletions.
9 changes: 1 addition & 8 deletions oci/spec_opts.go
Original file line number Diff line number Diff line change
Expand Up @@ -1192,20 +1192,13 @@ func WithDefaultUnixDevices(_ context.Context, _ Client, _ *containers.Container
Allow: true,
},
{
// "dev/ptmx"
Type: "c",
Major: intptr(5),
Minor: intptr(2),
Access: rwm,
Allow: true,
},
{
// tuntap
Type: "c",
Major: intptr(10),
Minor: intptr(200),
Access: rwm,
Allow: true,
},
}...)
return nil
}
Expand Down

0 comments on commit a3ac156

Please sign in to comment.