Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci cleanup #10

Open
henryiii opened this issue May 28, 2024 · 1 comment
Open

ci cleanup #10

henryiii opened this issue May 28, 2024 · 1 comment
Assignees

Comments

@henryiii
Copy link

henryiii commented May 28, 2024

Some suggested cleanup to build-wheels:

  • Currently there are three test jobs and three wheel build jobs; now that there's a ci.yml, the test jobs are either no longer needed, or should be moved.
  • The cibuildwheel and twine (should use the pypa publish action) should be moved out of a custom script and the action form should be used (can be pinned and updated with Dependabot, too)
  • macos-13 (last Intel) and macOS-14 (first AS) images should be used.
  • The custom arch stuff in pyproject.toml can then be removed, as native will work fine.

Also, "wheel" should not be listed in pyproject.toml, and backend = setuptools.build_meta is missing under [build-system].

See https://learn.scientific-python.org/development/guides/repo-review/?repo=thaler-lab%2FWasserstein&branch=master for other ideas.

@j-s-ashley j-s-ashley self-assigned this May 29, 2024
@j-s-ashley
Copy link
Member

j-s-ashley commented Jun 18, 2024

To break this down into referenceable steps:

build-wheels.yml

pyproject.toml

j-s-ashley added a commit to j-s-ashley/Wasserstein that referenced this issue Jun 18, 2024
j-s-ashley added a commit to j-s-ashley/Wasserstein that referenced this issue Jun 18, 2024
j-s-ashley added a commit to j-s-ashley/Wasserstein that referenced this issue Jun 18, 2024
j-s-ashley added a commit to j-s-ashley/Wasserstein that referenced this issue Jun 19, 2024
j-s-ashley added a commit that referenced this issue Jun 20, 2024
Addresses second half of #10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants