Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve formatting of punch from notification #74

Closed
tupaschoal opened this issue Oct 19, 2019 · 2 comments
Closed

Improve formatting of punch from notification #74

tupaschoal opened this issue Oct 19, 2019 · 2 comments
Assignees
Labels
enhancement New feature or request good first issue Good for newcomers hacktoberfest Hacktoberfest
Milestone

Comments

@tupaschoal
Copy link
Collaborator

#55 introduced punching from notification, but it emits a message that is "[H]?H:[m]?m", so these are a few examples on what looks like and what it should look like for different times:

  • 8:8 -> 08:08
  • 8:11 -> 08:11
  • 10:8 -> 10:08
@tupaschoal tupaschoal added enhancement New feature or request good first issue Good for newcomers hacktoberfest Hacktoberfest labels Oct 19, 2019
@tupaschoal tupaschoal added this to the Version 1.2.0 milestone Oct 19, 2019
@ozgunbal
Copy link
Contributor

I'm on it.

@thamara
Copy link
Owner

thamara commented Oct 20, 2019

Thanks @ozgunbal !

@thamara thamara closed this as completed Oct 20, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers hacktoberfest Hacktoberfest
Projects
None yet
Development

No branches or pull requests

3 participants