Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix grafana parse errors #74

Closed
wants to merge 5 commits into from
Closed

Fix grafana parse errors #74

wants to merge 5 commits into from

Conversation

jbfavre
Copy link

@jbfavre jbfavre commented Dec 6, 2019

2 small typos cause Grafana parse error on panels using theses expressions

Signed-off-by: Jean Baptiste Favre <github@jbfavre.org>
Signed-off-by: Jean Baptiste Favre <github@jbfavre.org>
Signed-off-by: Jean Baptiste Favre <github@jbfavre.org>
Signed-off-by: Jean Baptiste Favre <github@jbfavre.org>
@jbfavre
Copy link
Author

jbfavre commented Dec 9, 2019

Also update README.md
after running jb install github.com/metalmatze/kube-thanos/jsonnet/kube-thanos@master, ./build example.jsonnet gave me this error:

+ rm -rf manifests
+ mkdir manifests
+ jsonnet -J vendor -m manifests example.jsonnet
+ xargs '-I{}' sh -c 'cat {} | gojsontoyaml > {}.yaml; rm -f {}' -- '{}'
RUNTIME ERROR: field does not exist: variables
	vendor/kube-thanos/kube-thanos-querier.libsonnet:26:68-86	thunk <image>
	vendor/ksonnet/ksonnet.beta.4/k8s.libsonnet:22402:51-56	thunk <image>
	vendor/ksonnet/ksonnet.beta.4/k8s.libsonnet:22422:46-51	object <anonymous>
	vendor/kube-thanos/kube-thanos-store.libsonnet:(85:17)-(91:20)	thunk <array_element>
	vendor/kube-thanos/kube-thanos-store.libsonnet:(84:27)-(92:16)	object <anonymous>
	vendor/kube-thanos/kube-thanos-store.libsonnet:(82:22)-(94:12)	object <anonymous>
	vendor/kube-thanos/kube-thanos-store.libsonnet:(81:16)-(95:10)	object <anonymous>
	vendor/kube-thanos/kube-thanos-store.libsonnet:(80:20)-(96:8)	object <anonymous>
	example.jsonnet:30:1-104	object <anonymous>
	During manifestation

Using jb install github.com/thanos-io/kube-thanos/jsonnet/kube-thanos@master fixed the issue

Signed-off-by: Jean Baptiste Favre <github@jbfavre.org>
@kakkoyun
Copy link
Member

@jbfavre Thank you very much for catching this. We're currently working on the migration of thanos-mixin to Thanos itself, please see related PRs #67 and thanos-io/thanos#1760.

I have added your changes with this commit thanos-io/thanos@4d95064.

Therefore, I'm closing this one. Please feel free to comment on related PRs if you see any other issues.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants