Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove resource requests and limits #89

Merged
merged 2 commits into from
Jan 28, 2020

Conversation

metalmatze
Copy link
Contributor

Those requests and limits are too specific to the individual environments.
In the future, we can provide an example patch which should make it easier for people to add their specific needs. Let's wait until a bigger refactoring by @brancz landed though.

/cc @kakkoyun @squat @bwplotka

Signed-off-by: Matthias Loibl <mail@matthiasloibl.com>
Signed-off-by: Matthias Loibl <mail@matthiasloibl.com>
Copy link
Member

@kakkoyun kakkoyun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@metalmatze metalmatze merged commit 14ecdd5 into thanos-io:master Jan 28, 2020
@metalmatze metalmatze deleted the no-resources branch January 28, 2020 16:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants