Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Proposal] Volcano query planner #309

Closed

Conversation

tuannh982
Copy link

@tuannh982 tuannh982 commented Aug 22, 2023

Description:

Originally I tried to separate the AST, the logical plan and physical plan from #5. But ended up doing both separation and propose a new query planner

Related issues (might be)

Notes:

  • This is a proposal PR. It's only mean to describe how it might look like, not a full implementation. Do not merge

Signed-off-by: tuannh982 <tuannh982@gmail.com>
Signed-off-by: tuannh982 <tuannh982@gmail.com>
@tuannh982 tuannh982 force-pushed the separate-between-ast-and-execution branch from 0354272 to d8d7365 Compare August 22, 2023 18:12
@MichaHoffmann
Copy link
Contributor

Im ++1 for seperating physical plan and logical plan! Since thats a pretty big undertaking already can we split out the Planner maybe so it gets more feasible?

@bwplotka
Copy link
Member

Nice, quite a big refactor! Do you mind starting a quick discussion on #thanos-dev Slack channel about this? We could discuss it further. We would love to learn your use cases and plan with this advanced promql engine. Theory is one thing, but in practice it's hard to estimate true cost without knowing how much data we will have to fetch. We had some initial ideas to perform two-phase query (scan, fetch) but it's not there yet.

@tuannh982
Copy link
Author

@bwplotka thanks for reminding me, I will post this to #thanos-dev Slack channel for further discussion 👍

@tuannh982 tuannh982 closed this Sep 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants