[file-sd-part-5] Rule e2e test uses different service discovery options #556
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ivan-valkov
force-pushed
the
query-flag-rule
branch
from
3f90e9a
to
a2d9591
Compare
ivan-valkov
force-pushed
the
file-sd-rule-test
branch
2 times, most recently
from
8baeadf
to
5983f4c
Compare
ivan-valkov
force-pushed
the
query-flag-rule
branch
from
a2d9591
to
a337452
Compare
ivan-valkov
changed the title
ivan-valkov
force-pushed
the
file-sd-rule-test
branch
from
5983f4c
to
5ccc188
Compare
ivan-valkov
force-pushed
the
query-flag-rule
branch
from
a337452
to
d81dd66
Compare
ivan-valkov
force-pushed
the
file-sd-rule-test
branch
from
5ccc188
to
49aa48a
Compare
ivan-valkov
force-pushed
the
query-flag-rule
branch
from
d81dd66
to
e37fc01
Compare
ivan-valkov
force-pushed
the
file-sd-rule-test
branch
from
49aa48a
to
3aee969
Compare
ivan-valkov
force-pushed
the
query-flag-rule
branch
from
e37fc01
to
db61524
Compare
ivan-valkov
force-pushed
the
file-sd-rule-test
branch
from
3aee969
to
4b75414
Compare
ivan-valkov
force-pushed
the
query-flag-rule
branch
from
db61524
to
6150f6b
Compare
ivan-valkov
force-pushed
the
file-sd-rule-test
branch
from
4b75414
to
1e239d9
Compare
ivan-valkov
force-pushed
the
query-flag-rule
branch
from
6150f6b
to
d6e4c5a
Compare
ivan-valkov
force-pushed
the
file-sd-rule-test
branch
from
1e239d9
to
f34d64b
Compare
ivan-valkov
force-pushed
the
query-flag-rule
branch
from
d6e4c5a
to
136d7d6
Compare
ivan-valkov
force-pushed
the
file-sd-rule-test
branch
from
f34d64b
to
bb33631
Compare
ivan-valkov
commented
Oct 12, 2018
cmd/thanos/rule.go
Outdated
| @@ -70,7 +70,7 @@ func registerRule(m map[string]setupFunc, app *kingpin.Application, name string) | |||
| Default("2h")) | |||
| tsdbRetention := modelDuration(cmd.Flag("tsdb.retention", "Block retention time on local disk."). | |||
| Default("48h")) | |||
|
|
|||
| //TODO(ivan): add alertmanagers urls to file sd | |||
There was a problem hiding this comment.
Not, at the moment I would say ... lets leave it as it is slightly different to what we are currently changing.
ivan-valkov
force-pushed
the
query-flag-rule
branch
from
136d7d6
to
b7ec7a0
Compare
ivan-valkov
force-pushed
the
file-sd-rule-test
branch
from
bb33631
to
d4eaf04
Compare
ivan-valkov
force-pushed
the
query-flag-rule
branch
from
b7ec7a0
to
2e1dfe9
Compare
ivan-valkov
force-pushed
the
file-sd-rule-test
branch
from
d4eaf04
to
7ac03bc
Compare
domgreen
approved these changes
Oct 16, 2018
added 2 commits
October 16, 2018 13:59
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ref: #492
Changes
The rule e2e test now runs 3 times with different service discovery options:
Verification
The tests pass