-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(ui/blocks): fixing overlapping blocks for undefined poolArrays #7242
base: main
Are you sure you want to change the base?
fix(ui/blocks): fixing overlapping blocks for undefined poolArrays #7242
Conversation
It appears that `poolArray[0][0]` can return `undefined`, resulting in an error when trying to read `.thanos`. Signed-off-by: Markus Möslinger <markus.moeslinger@socra.dev>
Signed-off-by: Markus Möslinger <markus.moeslinger@socra.dev>
Signed-off-by: Markus Möslinger <markus.moeslinger@socra.dev>
An E2E test is failing:
Don't see why my change would cause a |
I believe it is a flake. Just re ran the test |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe you could try copying the tests from #7058 to see whether they pass?
Hey @outofrange, are you still planning to continue this PR? I think once we resolve conflicts it might be good to go and we can see if the issue is fixed |
It appears that
poolArray[0][0]
can returnundefined
, resulting in an error when trying to read.thanos
.I haven't dug deeper into why it's undefined, so there is a root cause that should be fixed instead?
Fixes #7216
Changes
Using
?.
to catch undefined poolArrays.Verification
If have only tested this with my Thanos deployment, which hasn't any overlapping blocks - can someone check if this works also when there are overlapping blocks present?