Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(ui/blocks): fixing overlapping blocks for undefined poolArrays #7242

Draft
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

outofrange
Copy link
Contributor

@outofrange outofrange commented Mar 28, 2024

It appears that poolArray[0][0] can return undefined, resulting in an error when trying to read .thanos.

I haven't dug deeper into why it's undefined, so there is a root cause that should be fixed instead?

  • I added CHANGELOG entry for this change.

Fixes #7216

Changes

Using ?. to catch undefined poolArrays.

Verification

If have only tested this with my Thanos deployment, which hasn't any overlapping blocks - can someone check if this works also when there are overlapping blocks present?

It appears that `poolArray[0][0]` can return `undefined`, resulting in an error when trying to read `.thanos`.

Signed-off-by: Markus Möslinger <markus.moeslinger@socra.dev>
Signed-off-by: Markus Möslinger <markus.moeslinger@socra.dev>
Signed-off-by: Markus Möslinger <markus.moeslinger@socra.dev>
@outofrange outofrange changed the title fix(ui/blocks): fixing overlapping blocks for empty poolArrays fix(ui/blocks): fixing overlapping blocks for undefined poolArrays Mar 28, 2024
@outofrange
Copy link
Contributor Author

An E2E test is failing:

15:27:12 toolsBucketWeb-1: ts=2024-03-28T15:27:12.979772333Z caller=runutil.go:117 level=error name=toolsBucketWeb-1 msg="function failed. Retrying in next tick" err="BaseFetcher: iter bucket: Get \"https://127.0.0.1:32790/toolsBucketWeb-test/?location=\": dial tcp 127.0.0.1:32790: connect: connection refused"
15:27:21 toolsBucketWeb-1: ts=2024-03-28T15:27:21.698806328Z caller=runutil.go:117 level=error name=toolsBucketWeb-1 msg="function failed. Retrying in next tick" err="BaseFetcher: iter bucket: Get \"https://127.0.0.1:32805/toolsBucketWeb-test/?location=\": dial tcp 127.0.0.1:32805: connect: connection refused"
panic: test timed out after 10m0s

Don't see why my change would cause a connection refused, but toolsBucketWeb at least looks like it could be related - or is this a flake?

@yeya24
Copy link
Contributor

yeya24 commented Mar 28, 2024

I believe it is a flake. Just re ran the test

Copy link
Member

@GiedriusS GiedriusS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe you could try copying the tests from #7058 to see whether they pass?

@yeya24
Copy link
Contributor

yeya24 commented Jul 13, 2024

Hey @outofrange, are you still planning to continue this PR? I think once we resolve conflicts it might be good to go and we can see if the issue is fixed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

bucketweb: attempting to view overlapping blocks results in error page
3 participants