*: Updating hashicorp LRU cache to v2 #7306
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Pedro Tanaka <pedro.tanaka@shopify.com>
Signed-off-by: Pedro Tanaka <pedro.tanaka@shopify.com>
|
@yeya24 pinging you for review since you implemented the first version. I dont see an easy way to use the expirable LRU from hashicorp directly, but if you have an idea tell me here and I will work on it. |
Signed-off-by: Pedro Tanaka <pedro.tanaka@shopify.com>
pedro-stanaka
force-pushed
the
use-expirable-cache
branch
2 times, most recently
from
c8206db
to
619d0eb
Compare
Signed-off-by: Pedro Tanaka <pedro.tanaka@shopify.com>
|
@pedro-stanaka Sorry I don't remember that I implemented the code at the beginning :( This PR looks good to me. Let's implement LRU expiration in a separate PR. WDYT? |
|
Yeah. From my side it would be okay to merge like this. Looking forward to approvals. 😆 |
Nashluffy
pushed a commit
to Nashluffy/thanos
that referenced
this pull request
May 14, 2024
* *: Updating hashicorp LRU cache to v2 Signed-off-by: Pedro Tanaka <pedro.tanaka@shopify.com> * Adding some new comments regarding removing complexity of TTL Signed-off-by: Pedro Tanaka <pedro.tanaka@shopify.com> * Using new version everywhere Signed-off-by: Pedro Tanaka <pedro.tanaka@shopify.com> * rephrase the comment Signed-off-by: Pedro Tanaka <pedro.tanaka@shopify.com> --------- Signed-off-by: Pedro Tanaka <pedro.tanaka@shopify.com> Signed-off-by: mluffman <nashluffman@gmail.com>
jnyi
pushed a commit
to jnyi/thanos
that referenced
this pull request
Jun 1, 2024
* *: Updating hashicorp LRU cache to v2 Signed-off-by: Pedro Tanaka <pedro.tanaka@shopify.com> * Adding some new comments regarding removing complexity of TTL Signed-off-by: Pedro Tanaka <pedro.tanaka@shopify.com> * Using new version everywhere Signed-off-by: Pedro Tanaka <pedro.tanaka@shopify.com> * rephrase the comment Signed-off-by: Pedro Tanaka <pedro.tanaka@shopify.com> --------- Signed-off-by: Pedro Tanaka <pedro.tanaka@shopify.com>
jnyi
pushed a commit
to jnyi/thanos
that referenced
this pull request
Jun 4, 2024
* *: Updating hashicorp LRU cache to v2 Signed-off-by: Pedro Tanaka <pedro.tanaka@shopify.com> * Adding some new comments regarding removing complexity of TTL Signed-off-by: Pedro Tanaka <pedro.tanaka@shopify.com> * Using new version everywhere Signed-off-by: Pedro Tanaka <pedro.tanaka@shopify.com> * rephrase the comment Signed-off-by: Pedro Tanaka <pedro.tanaka@shopify.com> --------- Signed-off-by: Pedro Tanaka <pedro.tanaka@shopify.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
I am upgrading the lib
github.com/hashicorp/golang-lruto a new major version in preparation for an upcoming PR.Verification
Unit tests, should not have big impact.