Add request ID to client grpc spans #7384
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fpetkovski
force-pushed
the
grpc-request-id
branch
from
2d85201
to
e208f22
Compare
This commit adds the request ID as a span tag to outgoing (client) http and gRPC requests. This would allow easier correlation of traces and logs using the request ID. Signed-off-by: Filip Petkovski <filip.petkovsky@gmail.com>
fpetkovski
force-pushed
the
grpc-request-id
branch
from
e208f22
to
1208806
Compare
MichaHoffmann
approved these changes
May 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit adds the request ID as a span tag to outgoing gRPC and incoming HTTP requests. This would allow easier correlation of traces and logs using the request ID. I still need to figure out how to attach this information to incoming gRPC tags.
Changes
Verification